From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: kernel-dev@rsta79.anonaddy.me, Hans de Goede <hansg@kernel.org>,
Andy Yang <andyybtc79@gmail.com>,
Mikko Juhani Korhonen <mjkorhon@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-ide@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v2 2/3] ata: ahci: Refactor ahci_broken_lpm()
Date: Wed, 11 Jun 2025 18:25:18 +0900 [thread overview]
Message-ID: <2f253dc7-35f3-4207-a662-eefb85e7c313@kernel.org> (raw)
In-Reply-To: <20250610110757.1318959-7-cassel@kernel.org>
On 6/10/25 8:08 PM, Niklas Cassel wrote:
> Currently, the match table in ahci_broken_lpm() contains DMI BIOS dates
> of BIOSes that are known to be working.
>
> Having a list of known to be working versions is usually the wrong way to
> do things (as this list could theoretically be infinite).
>
> Refactor this match table to contain DMI BIOS dates of BIOSes that are
> known to not be working, such that this list can be extended with BIOS
> versions (for other boards) that are known to not be working, where there
> is no good BIOS version (because all existing versions are broken).
>
> Reviewed-by: Hans de Goede <hansg@kernel.org>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-06-11 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 11:07 [PATCH v2 0/3] Cleanup ahci_broken_lpm() Niklas Cassel
2025-06-10 11:07 ` [PATCH v2 1/3] ata: ahci: Use correct BIOS build date for ThinkPad W541 quirk Niklas Cassel
2025-06-10 12:37 ` Hans de Goede
2025-06-11 9:23 ` Damien Le Moal
2025-06-10 11:08 ` [PATCH v2 2/3] ata: ahci: Refactor ahci_broken_lpm() Niklas Cassel
2025-06-11 9:25 ` Damien Le Moal [this message]
2025-06-10 11:08 ` [PATCH v2 3/3] ata: ahci: Disallow LPM for ASUSPRO-D840SA motherboard Niklas Cassel
2025-06-11 9:25 ` Damien Le Moal
2025-06-11 10:31 ` [PATCH v2 0/3] Cleanup ahci_broken_lpm() Niklas Cassel
2025-06-12 14:09 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f253dc7-35f3-4207-a662-eefb85e7c313@kernel.org \
--to=dlemoal@kernel.org \
--cc=andyybtc79@gmail.com \
--cc=cassel@kernel.org \
--cc=hansg@kernel.org \
--cc=kernel-dev@rsta79.anonaddy.me \
--cc=linux-ide@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mjkorhon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.