Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board

[Dragan Simic <dsimic@manjaro.org>]

Hello Tony,

Please see a few comments below.

On 2024-06-10 02:34, Tony Dinh wrote:
> - Change the spi-max-frequency to 50000000 (50 Mhz). According to the
> data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in
> the DTS to ensure u-boot is consistent with what Linux kernel expected.
> - Update GPIO fan to conform to the latest DT binding.

There's no need for the bullet points, plain prose will do fine instead.

> [1] 
> MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf

Unless you can provide a real, working URL for the datasheet, this 
reference
should actually be deleted.

> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
> ---
> 
>  arch/arm/dts/armada-385-thecus-n2350.dts | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts
> b/arch/arm/dts/armada-385-thecus-n2350.dts
> index 253cf01130..fdaa444e51 100644
> --- a/arch/arm/dts/armada-385-thecus-n2350.dts
> +++ b/arch/arm/dts/armada-385-thecus-n2350.dts
> @@ -2,7 +2,7 @@
>  /*
>   * Device Tree file for Thecus N2350 board
>   *
> - * Copyright (C) 2018-2023 Tony Dinh <mibodhi@gmail.com>
> + * Copyright (C) 2018-2024 Tony Dinh <mibodhi@gmail.com>
>   * Copyright (C) 2018 Manuel Jung <manuel.jung@hotmail.com>
>   */
> 
> @@ -143,9 +143,9 @@
>  	fan {
>  		compatible = "gpio-fan";
>  		gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>;
> -		gpio-fan,speed-map = <	  0  0
> -					600  1
> -					3000 2 >;
> +		gpio-fan,speed-map = <	  0  0>,
> +					<600  1>,
> +					<3000 2 >;
>  		pinctrl-0 = <&pmx_fan>;
>  		pinctrl-names = "default";
>  	};
> @@ -415,7 +415,7 @@
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
> 
> -		spi-max-frequency = <108000000>;
> +		spi-max-frequency = <50000000>;
>  		spi-cpha;
> 
>  		partition@0 {