Re: [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools

[Luca Boccassi <luca.boccassi@gmail.com>]

On Thu, 2019-03-21 at 11:44 +0000, Richard Purdie wrote:
> On Tue, 2019-03-19 at 18:15 +0000, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > 
> > Dumpimage and fit_check_sign can be used to extract kernel and
> > ramdisk from
> > a FIT file, verify them and kexec for a faster reboot.
> > 
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> >  meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > index ff26e32482..c487849bb2 100644
> > --- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > +++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > @@ -45,6 +45,14 @@ do_install () {
> >  	# mkenvimage
> >  	install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
> >  	ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
> > +
> > +	# dumpimage
> > +	install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
> > +	ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
> > +
> > +	# fit_check_sign
> > +	install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
> > fit_check_sign
> > +	ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
> >  }
> >  
> >  ALLOW_EMPTY_${PN} = "1"
> 
> Fails on musl:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/420
> https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/421
> no-x11:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/419
> qemux86-world:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/412
> 
> so basically it looks like any world build fails with this.
> 
> Cheers,
> 
> Richard

Hi,

Sorry about that, this recipe has changed a bit since sumo - it seems
the files need to be also listed individually in FILES_${PN}:

ERROR: u-boot-tools-1_2019.01-r0 do_package: QA Issue: u-boot-tools:
Files/directories were installed but not shipped in any package:
  /usr/bin/uboot-dumpimage
  /usr/bin/fit_check_sign
  /usr/bin/dumpimage
  /usr/bin/uboot-fit_check_sign
Please set FILES such that these items are packaged. Alternatively if
they are unneeded, avoid installing them or delete them within
do_install.

eg:

-FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
+FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage {bindir}/uboot-dumpimage ${bindir}/dumpimage {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"

Is this the right solution? Or should it be a new package?

-- 
Kind regards,
Luca Boccassi