From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH v3 2/3] drm/msm/dpu: handle failures while initializing displays Date: Mon, 17 Dec 2018 12:27:32 -0800 Message-ID: <2f841537ea6e8560bcfaea20079faded@codeaurora.org> References: <1544727064-26763-1-git-send-email-jsanka@codeaurora.org> <1544727064-26763-2-git-send-email-jsanka@codeaurora.org> <20181214152209.GQ154160@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181214152209.GQ154160@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0xMi0xNCAwNzoyMiwgU2VhbiBQYXVsIHdyb3RlOgo+IE9uIFRodSwgRGVjIDEzLCAy MDE4IGF0IDEwOjUxOjAzQU0gLTA4MDAsIEpleWt1bWFyIFNhbmthcmFuIHdyb3RlOgo+PiBCYWls IG91dCBLTVMgaHcgaW5pdCBvbiBkaXNwbGF5IGluaXRpYWxpemF0aW9uIGZhaWx1cmVzIHdpdGgK Pj4gcHJvcGVyIGVycm9yIGxvZ2dpbmcuCj4+IAo+PiBjaGFuZ2VzIGluIHYzOgo+PiAJLSBpbnRy b2R1Y2VkIGluIHRoZSBzZXJpZXMKPj4gCj4+IFNpZ25lZC1vZmYtYnk6IEpleWt1bWFyIFNhbmth cmFuIDxqc2Fua2FAY29kZWF1cm9yYS5vcmc+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL21z bS9kaXNwL2RwdTEvZHB1X2ttcy5jIHwgMzkKPiArKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo LSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVf a21zLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+PiBpbmRl eCA2ODU2ODZlLi4zOWM4NTQ5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rp c3AvZHB1MS9kcHVfa21zLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEv ZHB1X2ttcy5jCj4+IEBAIC00MDUsMzMgKzQwNSwzNiBAQCBzdGF0aWMgdm9pZCBkcHVfa21zX3dh aXRfZm9yX2NvbW1pdF9kb25lKHN0cnVjdAo+IG1zbV9rbXMgKmttcywKPj4gIAl9Cj4+ICB9Cj4+ IAo+PiAtc3RhdGljIHZvaWQgX2RwdV9rbXNfaW5pdGlhbGl6ZV9kc2koc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKPj4gK3N0YXRpYyBpbnQgX2RwdV9rbXNfaW5pdGlhbGl6ZV9kc2koc3RydWN0IGRy bV9kZXZpY2UgKmRldiwKPj4gIAkJCQkgICAgc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiwK Pj4gIAkJCQkgICAgc3RydWN0IGRwdV9rbXMgKmRwdV9rbXMpCj4+ICB7Cj4+ICAJc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyID0gTlVMTDsKPj4gLQlpbnQgaSwgcmM7Cj4+ICsJaW50IGksIHJj ID0gMDsKPj4gKwo+PiArCWlmICghKHByaXYtPmRzaVswXSB8fCBwcml2LT5kc2lbMV0pKQo+IAo+ IEl0J2QgYmUgbmljZSB0byBub3QgaGF2ZSB0byBzdXBwb3J0IGJvdGggYmxvY2tzIGlmIG9ubHkg b25lIGlzIGhvb2tlZCAKPiB1cC4KPiBQZXJoYXBzIG1vdmUgdGhlIFRPRE8gYmVsb3cgYWJvdmUg dGhpcyBjaGVjay4KPiAKPj4gKwkJcmV0dXJuIHJjOwo+PiAKPj4gIAkvKlRPRE86IFN1cHBvcnQg dHdvIGluZGVwZW5kZW50IERTSSBjb25uZWN0b3JzICovCj4+ICAJZW5jb2RlciA9IGRwdV9lbmNv ZGVyX2luaXQoZGV2LCBEUk1fTU9ERV9FTkNPREVSX0RTSSk7Cj4+IC0JaWYgKElTX0VSUl9PUl9O VUxMKGVuY29kZXIpKSB7Cj4+ICsJaWYgKElTX0VSUihlbmNvZGVyKSkgewo+PiAgCQlEUFVfRVJS T1IoImVuY29kZXIgaW5pdCBmYWlsZWQgZm9yIGRzaSBkaXNwbGF5XG4iKTsKPj4gLQkJcmV0dXJu Owo+PiArCQlyZXR1cm4gUFRSX0VSUihlbmNvZGVyKTsKPj4gIAl9Cj4+IAo+PiAgCWZvciAoaSA9 IDA7IGkgPCBBUlJBWV9TSVpFKHByaXYtPmRzaSk7IGkrKykgewo+PiAtCQlpZiAoIXByaXYtPmRz aVtpXSkgewo+PiAtCQkJRFBVX0RFQlVHKCJpbnZhbGlkIG1zbV9kc2kgZm9yIGN0cmwgJWRcbiIs IGkpOwo+PiAtCQkJcmV0dXJuOwo+PiAtCQl9Cj4+ICsJCWlmICghcHJpdi0+ZHNpW2ldKQo+IAo+ IEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBwb3NzaWJsZSBnaXZlbiB0aGUgY2hlY2sgYXQgdGhlIGJl Z2lubmluZyBvZiB0aGUKPiBmdW5jdGlvbgo+IApUaGUgY2hlY2sgYXQgdGhlIGJlZ2lubmluZyBy ZXR1cm5zIG9ubHkgaWYgQk9USCB0aGUgZHNpIGJsb2NrcyBhcmUgTlVMTC4KSW4gY2FzZSBvZiBm dWxsIGhkIHBhbmVsLCBvbmx5IG9uZSBvZiB0aGUgZHNpIGJsb2NrIHdpbGwgYmUgYWN0aXZlLiBU aGUKYWJvdmUgY2hlY2sgaXMgbmVlZGVkIHRvIHJldHVybiBvbiB0aGUgaW5hY3RpdmUgZHNpLgoK VGhhbmtzLApKZXlrdW1hciBTLgo+PiArCQkJY29udGludWU7Cj4+IAo+PiAgCQlyYyA9IG1zbV9k c2lfbW9kZXNldF9pbml0KHByaXYtPmRzaVtpXSwgZGV2LCBlbmNvZGVyKTsKPj4gIAkJaWYgKHJj KSB7Cj4+ICAJCQlEUFVfRVJST1IoIm1vZGVzZXRfaW5pdCBmYWlsZWQgZm9yIGRzaVslZF0sIHJj ID0KPiAlZFxuIiwKPj4gIAkJCQlpLCByYyk7Cj4+IC0JCQljb250aW51ZTsKPj4gKwkJCXJldHVy biByYzsKPj4gIAkJfQo+PiAgCX0KPj4gKwo+PiArCXJldHVybiByYzsKPiAKPiBuaXQ6IFlvdSBj YW4ga2VlcCByYyB1bmluaXRpYWxpemVkIGFib3ZlIGFuZCBqdXN0IHJldHVybiAwIGhlcmUuCj4g Cj4+ICB9Cj4+IAo+PiAgLyoqCj4+IEBAIC00NDIsMTYgKzQ0NSwyNCBAQCBzdGF0aWMgdm9pZCBf ZHB1X2ttc19pbml0aWFsaXplX2RzaShzdHJ1Y3QKPiBkcm1fZGV2aWNlICpkZXYsCj4+ICAgKiBA ZHB1X2ttczogICAgUG9pbnRlciB0byBkcHUga21zIHN0cnVjdHVyZQo+PiAgICogUmV0dXJuczog ICAgIFplcm8gb24gc3VjY2Vzcwo+PiAgICovCj4+IC1zdGF0aWMgdm9pZCBfZHB1X2ttc19zZXR1 cF9kaXNwbGF5cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiArc3RhdGljIGludCBfZHB1X2tt c19zZXR1cF9kaXNwbGF5cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgCQkJCSAgICBzdHJ1 Y3QgbXNtX2RybV9wcml2YXRlICpwcml2LAo+PiAgCQkJCSAgICBzdHJ1Y3QgZHB1X2ttcyAqZHB1 X2ttcykKPj4gIHsKPj4gLQlfZHB1X2ttc19pbml0aWFsaXplX2RzaShkZXYsIHByaXYsIGRwdV9r bXMpOwo+PiArCWludCByYyA9IDA7Cj4gCj4gbml0OiBObyBuZWVkIHRvIGluaXRpYWxpemUgdG8g MAo+IAo+PiArCj4+ICsJcmMgPSBfZHB1X2ttc19pbml0aWFsaXplX2RzaShkZXYsIHByaXYsIGRw dV9rbXMpOwo+PiArCWlmIChyYykgewo+PiArCQlEUFVfRVJST1IoImZhaWxlZCB0byBpbml0aWFs aXplIGRzaSwgcmMgPSAlZFxuIiwgcmMpOwo+PiArCQlyZXR1cm4gcmM7Cj4+ICsJfQo+PiAKPj4g IAkvKioKPj4gIAkgKiBFeHRlbmQgdGhpcyBmdW5jdGlvbiB0byBpbml0aWFsaXplIG90aGVyCj4+ ICAJICogdHlwZXMgb2YgZGlzcGxheXMKPj4gIAkgKi8KPj4gKwo+PiArCXJldHVybiByYzsKPj4g IH0KPj4gCj4+ICBzdGF0aWMgdm9pZCBfZHB1X2ttc19kcm1fb2JqX2Rlc3Ryb3koc3RydWN0IGRw dV9rbXMgKmRwdV9rbXMpCj4+IEBAIC01MTcsNyArNTI4LDExIEBAIHN0YXRpYyBpbnQgX2RwdV9r bXNfZHJtX29ial9pbml0KHN0cnVjdCBkcHVfa21zCj4gKmRwdV9rbXMpCj4+ICAJICogQ3JlYXRl IGVuY29kZXIgYW5kIHF1ZXJ5IGRpc3BsYXkgZHJpdmVycyB0byBjcmVhdGUKPj4gIAkgKiBicmlk Z2VzIGFuZCBjb25uZWN0b3JzCj4+ICAJICovCj4+IC0JX2RwdV9rbXNfc2V0dXBfZGlzcGxheXMo ZGV2LCBwcml2LCBkcHVfa21zKTsKPj4gKwlyZXQgPSBfZHB1X2ttc19zZXR1cF9kaXNwbGF5cyhk ZXYsIHByaXYsIGRwdV9rbXMpOwo+PiArCWlmIChyZXQpIHsKPj4gKwkJRFBVX0VSUk9SKCJmYWls ZWQgdG8gc2V0dXAgZGlzcGxheSwgcmMgPSAlZFxuIiwgcmV0KTsKPj4gKwkJZ290byBmYWlsOwo+ PiArCX0KPj4gCj4+ICAJbWF4X2NydGNfY291bnQgPSBtaW4oY2F0YWxvZy0+bWl4ZXJfY291bnQs Cj4+ICAJCQkgICAgICh1MzIpZGV2LT5tb2RlX2NvbmZpZy5udW1fZW5jb2Rlcik7Cj4+IC0tCj4+ IFRoZSBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiB0aGUg Q29kZSBBdXJvcmEKPiBGb3J1bSwKPj4gYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUg UHJvamVjdAo+PiAKPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPj4gRnJlZWRyZW5vIG1haWxpbmcgbGlzdAo+PiBGcmVlZHJlbm9AbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZnJlZWRyZW5vCgotLSAKSmV5a3VtYXIgUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9mcmVlZHJlbm8K