All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: linux-leds@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs
Date: Sun, 22 Mar 2020 16:28:43 +0100	[thread overview]
Message-ID: <2f95d545-7a4e-be9d-2826-5ea7cfdccfd6@gmail.com> (raw)
In-Reply-To: <20200321214449.0564a524@nic.cz>

Hi Marek,

On 3/21/20 9:44 PM, Marek Behun wrote:
> On Sat, 21 Mar 2020 19:55:15 +0100
> Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
> 
>> What is the rationale behind setting all LEDs to max_brighntess
>> on driver removal?
>>
> 
> For each RGB LED the microcontroller has ON/OFF setting, and color
> setting. When in HW triggering mode, the HW triggering manipulates the
> ON/OFF setting and the LED blinks with the color set by the color
> setting.
> 
> If I did not set color to white before driver removal, then the HW
> triggering would blink the LEDs with the color they had set by the
> user. That could be [0,0,0], so the LEDs wouldn't blink at all.
> 
> So on driver removal the LEDs are set into state in which they are after
> reset.

Sounds reasonable, ack.

-- 
Best regards,
Jacek Anaszewski

  reply	other threads:[~2020-03-22 15:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 18:16 [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs Marek Behún
2020-03-21 15:33 ` Pavel Machek
2020-03-28 12:08   ` Jacek Anaszewski
2020-03-28 12:27     ` Marek Behun
2020-03-28 12:36       ` Marek Behun
2020-03-28 13:01         ` Jacek Anaszewski
2020-03-28 17:20           ` Marek Behun
2020-03-29 12:53             ` Jacek Anaszewski
2020-04-02 14:29               ` Marek Behun
2020-04-02 20:19                 ` Jacek Anaszewski
2020-04-02 20:57                   ` Marek Behun
2020-04-02 21:00                     ` Jacek Anaszewski
2020-04-06 21:10                       ` Pavel Machek
2020-04-06 21:08           ` Pavel Machek
2020-04-06 20:42       ` Pavel Machek
2020-03-21 15:34 ` Pavel Machek
2020-03-21 18:01   ` Jacek Anaszewski
2020-03-21 20:50     ` Marek Behun
2020-03-22 15:51       ` Jacek Anaszewski
2020-04-06  8:34         ` Pavel Machek
2020-04-06 13:53           ` Marek Behun
2020-03-21 18:55 ` Jacek Anaszewski
2020-03-21 20:44   ` Marek Behun
2020-03-22 15:28     ` Jacek Anaszewski [this message]
2020-03-21 21:53 ` Marek Behun
2020-03-21 22:16   ` Pavel Machek
2020-03-21 22:36     ` Marek Behun
2020-03-22 15:50       ` Dan Murphy
2020-04-06  8:40       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f95d545-7a4e-be9d-2826-5ea7cfdccfd6@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.