From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA47CC433EF for ; Fri, 1 Apr 2022 09:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344780AbiDAJvf (ORCPT ); Fri, 1 Apr 2022 05:51:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344776AbiDAJve (ORCPT ); Fri, 1 Apr 2022 05:51:34 -0400 Received: from mx1.cqplus1.com (unknown [113.204.237.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E376F54BF1 for ; Fri, 1 Apr 2022 02:49:36 -0700 (PDT) X-MailGates: (flag:1,DYNAMIC,RELAY,NOHOST,LAN:PASS)(compute_score:DELIVE R,40,3) Received: from 172.27.96.203 by mx1.cqplus1.com with MailGates ESMTP Server V5.0(1179:0:AUTH_RELAY) (envelope-from ); Fri, 01 Apr 2022 17:46:50 +0800 (CST) Received: from CQEXMAIL01.cqplus1.com (172.27.96.203) by CQEXMAIL01.cqplus1.com (172.27.96.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 1 Apr 2022 17:47:49 +0800 Received: from CQEXMAIL01.cqplus1.com ([::1]) by CQEXMAIL01.cqplus1.com ([::1]) with mapi id 15.01.2375.018; Fri, 1 Apr 2022 17:47:49 +0800 From: =?utf-8?B?cWluamlhblvopoPlgaVd?= To: Arnd Bergmann CC: Krzysztof Kozlowski , Rob Herring , Michael Turquette , "Stephen Boyd" , Thomas Gleixner , Marc Zyngier , Philipp Zabel , "Russell King - ARM Linux" , Linux ARM , DTML , Linux Kernel Mailing List , linux-clk Subject: RE: [PATCH v12 5/9] clk: Add Sunplus SP7021 clock driver Thread-Topic: [PATCH v12 5/9] clk: Add Sunplus SP7021 clock driver Thread-Index: AQHYRNqOjCd6CVvOR0G759g8P20c0KzYsc4AgAIYlbA= Date: Fri, 1 Apr 2022 09:47:48 +0000 Message-ID: <2fa0ce6048f6449d883e2454ceea9540@cqplus1.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.110.18] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org PiANCj4gPiArc3RhdGljIGludCBzcF9wbGxfZW5hYmxlKHN0cnVjdCBjbGtfaHcgKmh3KQ0KPiA+ ICt7DQo+ID4gKyAgICAgICBzdHJ1Y3Qgc3BfcGxsICpjbGsgPSB0b19zcF9wbGwoaHcpOw0KPiA+ ICsgICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsNCj4gPiArDQo+ID4gKyAgICAgICBzcGluX2xv Y2tfaXJxc2F2ZShjbGstPmxvY2ssIGZsYWdzKTsNCj4gPiArICAgICAgIHdyaXRlbChCSVQoY2xr LT5wZF9iaXQgKyAxNikgfCBCSVQoY2xrLT5wZF9iaXQpLCBjbGstPnJlZyk7IC8qIHBvd2VyIHVw ICovDQo+ID4gKyAgICAgICBzcGluX3VubG9ja19pcnFyZXN0b3JlKGNsay0+bG9jaywgZmxhZ3Mp Ow0KPiA+ICsNCj4gPiArICAgICAgIHJldHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0 aWMgdm9pZCBzcF9wbGxfZGlzYWJsZShzdHJ1Y3QgY2xrX2h3ICpodykNCj4gPiArew0KPiA+ICsg ICAgICAgc3RydWN0IHNwX3BsbCAqY2xrID0gdG9fc3BfcGxsKGh3KTsNCj4gPiArICAgICAgIHVu c2lnbmVkIGxvbmcgZmxhZ3M7DQo+ID4gKw0KPiA+ICsgICAgICAgc3Bpbl9sb2NrX2lycXNhdmUo Y2xrLT5sb2NrLCBmbGFncyk7DQo+ID4gKyAgICAgICB3cml0ZWwoQklUKGNsay0+cGRfYml0ICsg MTYpLCBjbGstPnJlZyk7IC8qIHBvd2VyIGRvd24gKi8NCj4gPiArICAgICAgIHNwaW5fdW5sb2Nr X2lycXJlc3RvcmUoY2xrLT5sb2NrLCBmbGFncyk7DQo+ID4gK30NCj4gDQo+IFdoYXQgZG9lcyB0 aGUgc3BpbmxvY2sgYWN0dWFsbHkgcHJvdGVjdCBoZXJlPyBBcyB3cml0ZWwoKSBpcyBwb3N0ZWQs IGl0DQo+IGNhbiBhbHJlYWR5IGxlYWsgb2Ygb2YgdGhlIGxvY2ssIGFuZCB0aGUgaW5wdXRzIHdv dWxkIGFwcGVhciB0byBiZQ0KPiBjb25zdGFudC4NCj4gDQoNClRoZXNlIGNvZGUgaXMgcmVmZXJl ZCBmcm9tIG90aGVyIGNsayBkcml2ZXIuDQpCdXQsIG90aGVyIGRyaXZlciBuZWVkIHJlYWQgdGhl biB3cml0ZSwgc28gbmVlZCBsb2NrIHByb3RlY3RlZC4NCk91ciAgSFcgaXMgSElXT1JEX01BU0tF RF9SRUcsIG1lYW5zIG1vZGlmeSBiaXRzIG5vIG5lZWQgdG8gcmVhZCwganVzdCAxIHdyaXRlIG9u bHkuDQpTbywgdGhlIGxvY2sgaXMgdXNlbGVzcy4NCkRpZCBJIHJpZ2h0Pw0KDQo+ID4gKyAgICAg ICAvKiBUaGlzIG1lbW9yeSByZWdpb24gaW5jbHVkZSBtdWx0aSBIVyByZWdzIGluIGRpc2NvbnRp bnVvdXMgb3JkZXIuDQo+ID4gKyAgICAgICAgKiBjbGsgZHJpdmVyIHVzZWQgc29tZSBkaXNjb250 aW51b3VzIGFyZWFzIGluIHRoZSBtZW1vcnkgcmVnaW9uLg0KPiA+ICsgICAgICAgICogVXNpbmcg ZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKCkgd291bGQgY29uZmxpY3RlZCB3aXRoIG90 aGVyIGRyaXZlcnMuDQo+ID4gKyAgICAgICAgKi8NCj4gPiArICAgICAgIHJlcyA9IHBsYXRmb3Jt X2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMCk7DQo+ID4gKyAgICAgICBzcF9j bGtfYmFzZSA9IGRldm1faW9yZW1hcChkZXYsIHJlcy0+c3RhcnQsIHJlc291cmNlX3NpemUocmVz KSk7DQo+ID4gKyAgICAgICBpZiAoIXNwX2Nsa19iYXNlKQ0KPiA+ICsgICAgICAgICAgICAgICBy ZXR1cm4gLUVOWElPOw0KPiANCj4gQ2FuIHlvdSBleHBsYWluIHRoaXMgY29tbWVudCBpbiBtb3Jl IGRldGFpbD8gR2VuZXJhbGx5LCB0aGUgJ3JlZycgcHJvcGVydGllcw0KPiBvZiBkcml2ZXJzIHNo b3VsZCBub3Qgb3ZlcmxhcCwgc28gaXQgaXMgc3VwcG9zZWQgdG8gYmUgc2FmZSB0byBjYWxsDQo+ IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZSgpIGhlcmUuDQo+IA0KPiBXZSBkaXNjdXNz ZWQgdGhpcyBpbiB0aGUgY29udGV4dCBvZiB0aGUgaW9wIGRyaXZlciB0aGF0IGRpZCBoYXZlIG92 ZXJsYXBwaW5nDQo+IHJlZ2lzdGVycyB3aXRoIHRoaXMgZHJpdmVyLCBhbmQgdGhhdCB3YXMgaW5j b3JyZWN0LiBBcmUgdGhlcmUgYW55IG90aGVyIGRyaXZlcnMNCj4gdGhhdCBjb25mbGljdCB3aXRo IHRoZSBjbGsgZHJpdmVyPw0KPiANCj4gICAgICAgQXJuZA0KDQpJIG1lYW5zLCBJIG11c3Qgc3Bs aXQgdXAgdGhlIG9yaWdpbiByZWcgcmVnaW9uIGludG8gNCBzbWFsbCBwaWVjZXMsDQphbmQgY2Fs bCBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UoKSA0IHRpbWVzLg0KRGlkIEkgc2hvdWxk IGZvbGxvdyB0aGlzIHdheT8NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F276C433EF for ; Fri, 1 Apr 2022 09:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=icUkbJK4LpA/8ilmamtqfKRu6NfJoDWSMyi9+9v9Too=; b=ku0POooEsOofY5 DumNDAuZxdlOPInwbnnMeCpFsVBRDxGFQ6Tk/BSiGECLnkOhN3na9RihBPD66IqX3u5gK43nCeTvx BzWqwMWo8KOPGjOkvH14xmnDq2yDyZXkFlfd6XVL6JLgJU/uiNi+kSt2ESZ6QCYK1rLCwnR3RWCq2 HRKoRoO2QRLvY7nh/2DHV8IfNXdVw/nV8YWHB4RounEi41b+jk6WpsuleoI76hSVSxkjBwCoprKh7 kDGlMwL1FGYLUUwWzMCPm+XV3n4F81+5jPIH2Ni7svrFyw5AA7eH8T7sBOL5M5kqnWrFREshsih3/ uNjO8SPuAl9U5sJGNyNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naDtd-0055zb-PO; Fri, 01 Apr 2022 09:48:45 +0000 Received: from mx1.cqplus1.com ([113.204.237.245]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naDtX-0055xe-Rh for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 09:48:44 +0000 X-MailGates: (flag:1,DYNAMIC,RELAY,NOHOST,LAN:PASS)(compute_score:DELIVE R,40,3) Received: from 172.27.96.203 by mx1.cqplus1.com with MailGates ESMTP Server V5.0(1179:0:AUTH_RELAY) (envelope-from ); Fri, 01 Apr 2022 17:46:50 +0800 (CST) Received: from CQEXMAIL01.cqplus1.com (172.27.96.203) by CQEXMAIL01.cqplus1.com (172.27.96.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 1 Apr 2022 17:47:49 +0800 Received: from CQEXMAIL01.cqplus1.com ([::1]) by CQEXMAIL01.cqplus1.com ([::1]) with mapi id 15.01.2375.018; Fri, 1 Apr 2022 17:47:49 +0800 From: =?utf-8?B?cWluamlhblvopoPlgaVd?= To: Arnd Bergmann CC: Krzysztof Kozlowski , Rob Herring , Michael Turquette , "Stephen Boyd" , Thomas Gleixner , Marc Zyngier , Philipp Zabel , "Russell King - ARM Linux" , Linux ARM , DTML , Linux Kernel Mailing List , linux-clk Subject: RE: [PATCH v12 5/9] clk: Add Sunplus SP7021 clock driver Thread-Topic: [PATCH v12 5/9] clk: Add Sunplus SP7021 clock driver Thread-Index: AQHYRNqOjCd6CVvOR0G759g8P20c0KzYsc4AgAIYlbA= Date: Fri, 1 Apr 2022 09:47:48 +0000 Message-ID: <2fa0ce6048f6449d883e2454ceea9540@cqplus1.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.110.18] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_024840_298017_5914F36B X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > +static int sp_pll_enable(struct clk_hw *hw) > > +{ > > + struct sp_pll *clk = to_sp_pll(hw); > > + unsigned long flags; > > + > > + spin_lock_irqsave(clk->lock, flags); > > + writel(BIT(clk->pd_bit + 16) | BIT(clk->pd_bit), clk->reg); /* power up */ > > + spin_unlock_irqrestore(clk->lock, flags); > > + > > + return 0; > > +} > > + > > +static void sp_pll_disable(struct clk_hw *hw) > > +{ > > + struct sp_pll *clk = to_sp_pll(hw); > > + unsigned long flags; > > + > > + spin_lock_irqsave(clk->lock, flags); > > + writel(BIT(clk->pd_bit + 16), clk->reg); /* power down */ > > + spin_unlock_irqrestore(clk->lock, flags); > > +} > > What does the spinlock actually protect here? As writel() is posted, it > can already leak of of the lock, and the inputs would appear to be > constant. > These code is refered from other clk driver. But, other driver need read then write, so need lock protected. Our HW is HIWORD_MASKED_REG, means modify bits no need to read, just 1 write only. So, the lock is useless. Did I right? > > + /* This memory region include multi HW regs in discontinuous order. > > + * clk driver used some discontinuous areas in the memory region. > > + * Using devm_platform_ioremap_resource() would conflicted with other drivers. > > + */ > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + sp_clk_base = devm_ioremap(dev, res->start, resource_size(res)); > > + if (!sp_clk_base) > > + return -ENXIO; > > Can you explain this comment in more detail? Generally, the 'reg' properties > of drivers should not overlap, so it is supposed to be safe to call > devm_platform_ioremap_resource() here. > > We discussed this in the context of the iop driver that did have overlapping > registers with this driver, and that was incorrect. Are there any other drivers > that conflict with the clk driver? > > Arnd I means, I must split up the origin reg region into 4 small pieces, and call devm_platform_ioremap_resource() 4 times. Did I should follow this way? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel