Re: [PATCH v2 3/4] tests/functional: Convert Aspeed arm SDK tests

[Thomas Huth <thuth@redhat.com>]

On 12/11/2024 14.02, Cédric Le Goater wrote:
> Drop the SSH connection which was introduced in the avocado tests to
> workaround read issues when interacting with console.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/avocado/machine_aspeed.py     | 124 ----------------------------
>   tests/functional/test_arm_aspeed.py |  67 +++++++++++++++
>   2 files changed, 67 insertions(+), 124 deletions(-)
>   delete mode 100644 tests/avocado/machine_aspeed.py
> 
> diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py
> deleted file mode 100644
> index 2240c82abff9..000000000000
> --- a/tests/avocado/machine_aspeed.py
> +++ /dev/null
> @@ -1,124 +0,0 @@
> -# Functional test that boots the ASPEED SoCs with firmware
> -#
> -# Copyright (C) 2022 ASPEED Technology Inc
> -#
> -# This work is licensed under the terms of the GNU GPL, version 2 or
> -# later.  See the COPYING file in the top-level directory.
> -
> -import time
> -import os
> -import tempfile
> -import subprocess
> -
> -from avocado_qemu import LinuxSSHMixIn
> -from avocado_qemu import QemuSystemTest
> -from avocado_qemu import wait_for_console_pattern
> -from avocado_qemu import exec_command
> -from avocado_qemu import exec_command_and_wait_for_pattern
> -from avocado_qemu import interrupt_interactive_console_until_pattern
> -from avocado_qemu import has_cmd
> -from avocado.utils import archive
> -from avocado import skipUnless
> -
> -class AST2x00MachineSDK(QemuSystemTest, LinuxSSHMixIn):
> -
> -    EXTRA_BOOTARGS = (
> -        'quiet '
> -        'systemd.mask=org.openbmc.HostIpmi.service '
> -        'systemd.mask=xyz.openbmc_project.Chassis.Control.Power@0.service '
> -        'systemd.mask=modprobe@fuse.service '
> -        'systemd.mask=rngd.service '
> -        'systemd.mask=obmc-console@ttyS2.service '
> -    )

What about that EXTRA_BOOTARGS stuff? Is it not required/wanted in the new 
file anymore? ... maybe mention it at least in the commit description?

  Thomas