Re: [PATCH v2] crypto: qat - fix active_devs leak on crypto alg registration failure

[Thomas Huth <thuth@redhat.com>]

On 08/09/2026 14.10, Ahsan Atta wrote:
> adf_dev_start() registered both alg sets in a single condition.
> If qat_algs_register() succeeds but qat_asym_algs_register() fails,
> ADF_STATUS_CRYPTO_ALGS_REGISTERED is left clear, so adf_dev_stop() skips
> qat_algs_unregister(): the skciphers and aeads stay registered with
> active_devs stuck at 1, pinning the module.
> 
> Both helpers leak active_devs internally as well - they increment it and
> return without decrementing when a crypto_register_*() call fails, and
> the asym path also leaves the already-registered akcipher behind.
> 
> Split the registration in adf_dev_start() so that an asym failure
> unregisters qat_algs, and unwind active_devs (and the akcipher) on the
> error paths of both register helpers. While at it, propagate the error
> code returned by the register helpers instead of a blanket -EFAULT.
> 
> Fixes: 9b2f33a1bfcd ("crypto: qat - fix unregistration of crypto algorithms")
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> Changes in v2:
> - adf_dev_start(): propagate the error code returned by qat_algs_register()
>    and qat_asym_algs_register() instead of returning a blanket -EFAULT.
> 
>   .../crypto/intel/qat/qat_common/adf_init.c    | 24 ++++++++++++-----
>   .../crypto/intel/qat/qat_common/qat_algs.c    | 15 ++++++-----
>   .../intel/qat/qat_common/qat_asym_algs.c      | 26 ++++++++++++++-----
>   3 files changed, 45 insertions(+), 20 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>