From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8335B46BE for ; Wed, 16 Aug 2023 01:57:57 +0000 (UTC) Received: from out-51.mta1.migadu.com (out-51.mta1.migadu.com [IPv6:2001:41d0:203:375::33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AF34212E for ; Tue, 15 Aug 2023 18:57:50 -0700 (PDT) Message-ID: <2fd02263-669f-82cf-d2c0-86fb5e4ad993@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692151068; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0oLzcpuisQPOwYQEpTGqv/JCJ88xAmPPG5jHaEZptyI=; b=XzHoLuW24og1pQCr7dfz/7QuWvyYJ0f0m49NVASvS7VrPABQQpyCZaalDoIAHNM6L7CbxV Tvuse7bkgQH0sI57NWBM2+O+jGSgc24aXWGIuaW4f/4/x1cIM1oW6snb9iLTTTFtrsMRCq snJMjzf60o4mq8blaKXeo2yajCNt4t4= Date: Tue, 15 Aug 2023 18:57:39 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-To: yonghong.song@linux.dev Subject: Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64 Content-Language: en-US To: Xu Kuohai , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Alexei Starovoitov , Andrii Nakryiko , Catalin Marinas , Daniel Borkmann , Martin KaFai Lau , Will Deacon , Mark Rutland , Yonghong Song , Zi Shen Lim References: <20230815154158.717901-1-xukuohai@huaweicloud.com> <20230815154158.717901-8-xukuohai@huaweicloud.com> <67212714-15f3-84e8-d5c6-84746632eedd@huaweicloud.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <67212714-15f3-84e8-d5c6-84746632eedd@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 8/15/23 6:28 PM, Xu Kuohai wrote: > On 8/16/2023 12:57 AM, Yonghong Song wrote: >> >> >> On 8/15/23 8:41 AM, Xu Kuohai wrote: >>> From: Xu Kuohai >>> >>> Enable cpu v4 instruction tests for arm64. >>> >>> Signed-off-by: Xu Kuohai >> >> Thanks for adding cpu v4 support for arm64. The CI looks green as well >> for arm64. >> >> https://github.com/kernel-patches/bpf/actions/runs/5868919914/job/15912774884?pr=5525 >> > > Well, it looks like the CI's clang doesn't support cpu v4 yet: > >   #306/1   verifier_bswap/cpuv4 is not supported by compiler or jit, > use a dummy test:OK >   #306     verifier_bswap:OK > >> Ack this patch which enabled cpu v4 tests for arm64. Ah. Sorry. Could you paste your local cpu v4 run results for these related tests in the commit message then? >> >> Acked-by: Yonghong Song >> >>> --- >>>   tools/testing/selftests/bpf/progs/test_ldsx_insn.c | 2 +- >>>   tools/testing/selftests/bpf/progs/verifier_bswap.c | 2 +- >>>   tools/testing/selftests/bpf/progs/verifier_gotol.c | 2 +- >>>   tools/testing/selftests/bpf/progs/verifier_ldsx.c  | 2 +- >>>   tools/testing/selftests/bpf/progs/verifier_movsx.c | 2 +- >>>   tools/testing/selftests/bpf/progs/verifier_sdiv.c  | 2 +- >>>   6 files changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c >>> b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c >>> index 321abf862801..916d9435f12c 100644 >>> --- a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c >>> +++ b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c >>> @@ -5,7 +5,7 @@ >>>   #include >>>   #include >>> -#if defined(__TARGET_ARCH_x86) && __clang_major__ >= 18 >>> +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && >>> __clang_major__ >= 18 >>>   const volatile int skip = 0; >>>   #else >>>   const volatile int skip = 1; >> [...] >> >> . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AF34C0015E for ; Wed, 16 Aug 2023 01:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zNeNUWpwPoLeJ/X5s65llQPurnBLA1I/4ZenHdjSTy4=; b=M2UxUh+1fstw9Q QPL/jk0M1LbCLnjqL5Wt5+SE3OWGLdnkZf4Vr1SBJZyXRj0mCRNaREmh/SNj2MPQm4lUZpV1blyyl y4bmlsFMoiE67SEHGikCaJEvEjymEmTMLTpa0zcSaKnQTdYgd5+HCTDxKQ5X7aYkYbECx1fNcgUbs JeoL7QT6OGkIdRYrpeJR75xFYKQl320JLrEPPelcu4YIAZbfaT76LJLiyvXPjp6+czRRmfQ0G58VZ xV7USu8lEhxN35/v1v6fQoTUFt5sW85L3nwYKknTOfEzsGC7hiYXgPsmdwXuQrk4eRP9s+2WLJyw3 ZjMx4+I48HEdLndGkBUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qW5nL-002yNQ-00; Wed, 16 Aug 2023 01:57:59 +0000 Received: from out-21.mta1.migadu.com ([2001:41d0:203:375::15]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qW5nG-002yMX-22 for linux-arm-kernel@lists.infradead.org; Wed, 16 Aug 2023 01:57:57 +0000 Message-ID: <2fd02263-669f-82cf-d2c0-86fb5e4ad993@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692151068; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0oLzcpuisQPOwYQEpTGqv/JCJ88xAmPPG5jHaEZptyI=; b=XzHoLuW24og1pQCr7dfz/7QuWvyYJ0f0m49NVASvS7VrPABQQpyCZaalDoIAHNM6L7CbxV Tvuse7bkgQH0sI57NWBM2+O+jGSgc24aXWGIuaW4f/4/x1cIM1oW6snb9iLTTTFtrsMRCq snJMjzf60o4mq8blaKXeo2yajCNt4t4= Date: Tue, 15 Aug 2023 18:57:39 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64 Content-Language: en-US To: Xu Kuohai , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Alexei Starovoitov , Andrii Nakryiko , Catalin Marinas , Daniel Borkmann , Martin KaFai Lau , Will Deacon , Mark Rutland , Yonghong Song , Zi Shen Lim References: <20230815154158.717901-1-xukuohai@huaweicloud.com> <20230815154158.717901-8-xukuohai@huaweicloud.com> <67212714-15f3-84e8-d5c6-84746632eedd@huaweicloud.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <67212714-15f3-84e8-d5c6-84746632eedd@huaweicloud.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_185755_413967_E7C91704 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: yonghong.song@linux.dev Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA4LzE1LzIzIDY6MjggUE0sIFh1IEt1b2hhaSB3cm90ZToKPiBPbiA4LzE2LzIwMjMgMTI6 NTcgQU0sIFlvbmdob25nIFNvbmcgd3JvdGU6Cj4+Cj4+Cj4+IE9uIDgvMTUvMjMgODo0MSBBTSwg WHUgS3VvaGFpIHdyb3RlOgo+Pj4gRnJvbTogWHUgS3VvaGFpIDx4dWt1b2hhaUBodWF3ZWkuY29t Pgo+Pj4KPj4+IEVuYWJsZSBjcHUgdjQgaW5zdHJ1Y3Rpb24gdGVzdHMgZm9yIGFybTY0Lgo+Pj4K Pj4+IFNpZ25lZC1vZmYtYnk6IFh1IEt1b2hhaSA8eHVrdW9oYWlAaHVhd2VpLmNvbT4KPj4KPj4g VGhhbmtzIGZvciBhZGRpbmcgY3B1IHY0IHN1cHBvcnQgZm9yIGFybTY0LiBUaGUgQ0kgbG9va3Mg Z3JlZW4gYXMgd2VsbCAKPj4gZm9yIGFybTY0Lgo+Pgo+PiBodHRwczovL2dpdGh1Yi5jb20va2Vy bmVsLXBhdGNoZXMvYnBmL2FjdGlvbnMvcnVucy81ODY4OTE5OTE0L2pvYi8xNTkxMjc3NDg4ND9w cj01NTI1Cj4+Cj4gCj4gV2VsbCwgaXQgbG9va3MgbGlrZSB0aGUgQ0kncyBjbGFuZyBkb2Vzbid0 IHN1cHBvcnQgY3B1IHY0IHlldDoKPiAKPiAgwqAgIzMwNi8xwqDCoCB2ZXJpZmllcl9ic3dhcC9j cHV2NCBpcyBub3Qgc3VwcG9ydGVkIGJ5IGNvbXBpbGVyIG9yIGppdCwgCj4gdXNlIGEgZHVtbXkg dGVzdDpPSwo+ICDCoCAjMzA2wqDCoMKgwqAgdmVyaWZpZXJfYnN3YXA6T0sKPiAKPj4gQWNrIHRo aXMgcGF0Y2ggd2hpY2ggZW5hYmxlZCBjcHUgdjQgdGVzdHMgZm9yIGFybTY0LgoKQWguIFNvcnJ5 LiBDb3VsZCB5b3UgcGFzdGUgeW91ciBsb2NhbCBjcHUgdjQgcnVuIHJlc3VsdHMgZm9yCnRoZXNl IHJlbGF0ZWQgdGVzdHMgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIHRoZW4/Cgo+Pgo+PiBBY2tlZC1i eTogWW9uZ2hvbmcgU29uZyA8eW9uZ2hvbmcuc29uZ0BsaW51eC5kZXY+Cj4+Cj4+PiAtLS0KPj4+ IMKgIHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2JwZi9wcm9ncy90ZXN0X2xkc3hfaW5zbi5jIHwg MiArLQo+Pj4gwqAgdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvYnBmL3Byb2dzL3ZlcmlmaWVyX2Jz d2FwLmMgfCAyICstCj4+PiDCoCB0b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9icGYvcHJvZ3MvdmVy aWZpZXJfZ290b2wuYyB8IDIgKy0KPj4+IMKgIHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2JwZi9w cm9ncy92ZXJpZmllcl9sZHN4LmPCoCB8IDIgKy0KPj4+IMKgIHRvb2xzL3Rlc3Rpbmcvc2VsZnRl c3RzL2JwZi9wcm9ncy92ZXJpZmllcl9tb3ZzeC5jIHwgMiArLQo+Pj4gwqAgdG9vbHMvdGVzdGlu Zy9zZWxmdGVzdHMvYnBmL3Byb2dzL3ZlcmlmaWVyX3NkaXYuY8KgIHwgMiArLQo+Pj4gwqAgNiBm aWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlm ZiAtLWdpdCBhL3Rvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2JwZi9wcm9ncy90ZXN0X2xkc3hfaW5z bi5jIAo+Pj4gYi90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9icGYvcHJvZ3MvdGVzdF9sZHN4X2lu c24uYwo+Pj4gaW5kZXggMzIxYWJmODYyODAxLi45MTZkOTQzNWYxMmMgMTAwNjQ0Cj4+PiAtLS0g YS90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9icGYvcHJvZ3MvdGVzdF9sZHN4X2luc24uYwo+Pj4g KysrIGIvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvYnBmL3Byb2dzL3Rlc3RfbGRzeF9pbnNuLmMK Pj4+IEBAIC01LDcgKzUsNyBAQAo+Pj4gwqAgI2luY2x1ZGUgPGJwZi9icGZfaGVscGVycy5oPgo+ Pj4gwqAgI2luY2x1ZGUgPGJwZi9icGZfdHJhY2luZy5oPgo+Pj4gLSNpZiBkZWZpbmVkKF9fVEFS R0VUX0FSQ0hfeDg2KSAmJiBfX2NsYW5nX21ham9yX18gPj0gMTgKPj4+ICsjaWYgKGRlZmluZWQo X19UQVJHRVRfQVJDSF9hcm02NCkgfHwgZGVmaW5lZChfX1RBUkdFVF9BUkNIX3g4NikpICYmIAo+ Pj4gX19jbGFuZ19tYWpvcl9fID49IDE4Cj4+PiDCoCBjb25zdCB2b2xhdGlsZSBpbnQgc2tpcCA9 IDA7Cj4+PiDCoCAjZWxzZQo+Pj4gwqAgY29uc3Qgdm9sYXRpbGUgaW50IHNraXAgPSAxOwo+PiBb Li4uXQo+Pgo+PiAuCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==