Re: [PATCH] drm/i915: Remove success dmesg noise for intel_rotate_pages()

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 22/11/2017 14:56, Chris Wilson wrote:
> During selftesting intel_rotate_pages() is very, very verbose without
> giving us any information. Suppress the noise.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index e101b9a98957..41a203e0c160 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -3737,9 +3737,6 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
>   				  rot_info->plane[i].stride, st, sg);
>   	}
>   
> -	DRM_DEBUG_KMS("Created rotated page mapping for object size %zu (%ux%u tiles, %u pages)\n",
> -		      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> -

Fair.

>   	kvfree(page_addr_list);
>   
>   	return st;
> @@ -3749,8 +3746,8 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
>   err_st_alloc:
>   	kvfree(page_addr_list);
>   
> -	DRM_DEBUG_KMS("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> -		      obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);
> +	DRM_DEBUG_DRIVER("Failed to create rotated mapping for object size %zu! (%ux%u tiles, %u pages)\n",
> +			 obj->base.size, rot_info->plane[0].width, rot_info->plane[0].height, size);

Keep the failure perhaps?

Regards,

Tvrtko

>   
>   	return ERR_PTR(ret);
>   }
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx