From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexandru Chimac <alex@chimac.ro>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: clock: samsung: Add Exynos9610 CMU bindings
Date: Fri, 24 Jul 2026 08:14:14 +0200 [thread overview]
Message-ID: <2ff56bb7-e929-4495-a524-6c72071de40c@kernel.org> (raw)
In-Reply-To: <20260724-supportive-jasmine-bandicoot-ed2c8c@quoll>
On 24/07/2026 08:13, Krzysztof Kozlowski wrote:
> On Wed, Jul 22, 2026 at 11:44:02PM +0300, Alexandru Chimac wrote:
>> This clock management unit has a topmost block (CMU_TOP)
>> that generates top clocks for other blocks, alongside 20
>> other blocks, out of which 11 are currently implemented.
>
> This feels not properly wrapped.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
>>
>> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
>> ---
>> .../bindings/clock/samsung,exynos9610-cmu.yaml | 335 ++++++++++
>> include/dt-bindings/clock/samsung,exynos9610-cmu.h | 722 +++++++++++++++++++++
>> 2 files changed, 1057 insertions(+)
>
> ...
And since I expect new version:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-24 6:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 20:44 [PATCH v3 0/5] clk: samsung: Introduce support for Exynos9610 clocks Alexandru Chimac
2026-07-22 20:44 ` [PATCH v3 1/5] dt-bindings: clock: samsung: Add Exynos9610 CMU bindings Alexandru Chimac
2026-07-24 6:13 ` Krzysztof Kozlowski
2026-07-24 6:14 ` Krzysztof Kozlowski [this message]
2026-07-22 20:44 ` [PATCH v3 2/5] dt-bindings: soc: exynos-sysreg: Add Exynos9610 SYSREG bindings Alexandru Chimac
2026-07-23 12:02 ` Peter Griffin
2026-07-22 20:44 ` [PATCH v3 3/5] clk: samsung: clk-pll: Add support for pll_1061x Alexandru Chimac
2026-07-22 20:44 ` [PATCH v3 4/5] clk: samsung: Introduce Exynos9610 clock controller driver Alexandru Chimac
2026-07-22 21:01 ` sashiko-bot
2026-07-23 11:52 ` Peter Griffin
2026-07-23 19:35 ` Alexandru Chimac
2026-07-22 20:44 ` [PATCH v3 5/5] MAINTAINERS: Add entry for Exynos9610 Alexandru Chimac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff56bb7-e929-4495-a524-6c72071de40c@kernel.org \
--to=krzk@kernel.org \
--cc=alex@chimac.ro \
--cc=alim.akhtar@samsung.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.