From: Pavel Reichl <preichl@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: remove deprecated mount options
Date: Fri, 25 Sep 2020 15:38:56 +0200 [thread overview]
Message-ID: <2ff5f20a-88ca-5822-6497-ed3c486d794c@redhat.com> (raw)
In-Reply-To: <20200924174913.GI7955@magnolia>
that handled the !IKEEP behavior.
>>>
>>>> + return 0;
>>>> + case Opt_noikeep:
>>>> + xfs_warn(mp, "%s mount option is deprecated.", param->key);
>>>> + mp->m_flags &= ~XFS_MOUNT_IKEEP;
>>>> + return 0;
>>>> + case Opt_attr2:
>>>> + xfs_warn(mp, "%s mount option is deprecated.", param->key);
>>>> + mp->m_flags |= XFS_MOUNT_ATTR2;
>
> Side note: shouldn't this clause be clearing XFS_MOUNT_NOATTR2?
>
I don't know but since nobody complained so far and we are actually starting work to remove it...I think it's safe to ignore that...?
next prev parent reply other threads:[~2020-09-25 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 17:07 [PATCH 0/2] xfs: remove deprecated mount and sysctl options Pavel Reichl
2020-09-24 17:07 ` [PATCH 1/2] xfs: remove deprecated mount options Pavel Reichl
2020-09-24 17:26 ` Darrick J. Wong
2020-09-24 17:39 ` Eric Sandeen
2020-09-24 17:49 ` Darrick J. Wong
2020-09-25 13:38 ` Pavel Reichl [this message]
2020-09-25 13:40 ` Pavel Reichl
2020-09-25 14:50 ` Eric Sandeen
2020-09-25 15:54 ` Darrick J. Wong
2020-09-24 17:07 ` [PATCH 2/2] xfs: remove deprecated sysctl options Pavel Reichl
2020-09-24 17:27 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff5f20a-88ca-5822-6497-ed3c486d794c@redhat.com \
--to=preichl@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.