From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: kys@microsoft.com, haiyangz@microsoft.com, davem@davemloft.net,
netdev@vger.kernel.org,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH net] failover: eliminate callback hell
Date: Mon, 11 Jun 2018 17:08:29 -0700 [thread overview]
Message-ID: <2ffcd7c4-17bf-2e7b-fd48-d61b2a6f2ade@intel.com> (raw)
In-Reply-To: <04210bba-f67a-dd10-cdce-c7d140dcecbe@intel.com>
On 6/11/2018 12:34 PM, Samudrala, Sridhar wrote:
>
> On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote:
>> On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:
>>> * Set permanent and current address of net_failover device
>>> to match the primary.
We copy the dev_addr of standby dev to failover_dev in net_failover_create()
before calling register_netdev().
register_netdev() does a copy of dev_addr to perm_addr.
So i don't think this is an issue.
>>>
>>> * Carrier should be marked off before registering device
>>> the net_failover device.
Will fix this and also a couple of places dev_err() needs to be replaced with netdev_err()
>> Sridhar, do we want to address this?
>> If yes, could you please take a look at addressing these
>> meanwhile, while we keep arguing about making API changes?
>
> Sure. I will submit patches to address these issues raised by Stephen.
>
>
prev parent reply other threads:[~2018-06-12 0:08 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 3:42 [PATCH net] failover: eliminate callback hell Stephen Hemminger
2018-06-05 17:22 ` Samudrala, Sridhar
2018-06-05 17:45 ` Stephen Hemminger
2018-06-05 18:14 ` David Miller
2018-06-05 18:35 ` Michael S. Tsirkin
2018-06-05 18:53 ` Stephen Hemminger
2018-06-05 19:38 ` Michael S. Tsirkin
2018-06-05 21:52 ` Stephen Hemminger
2018-06-05 23:52 ` Samudrala, Sridhar
2018-06-06 3:51 ` Stephen Hemminger
2018-06-06 5:39 ` Samudrala, Sridhar
2018-06-06 6:00 ` Stephen Hemminger
2018-06-06 6:11 ` Samudrala, Sridhar
2018-06-06 21:16 ` Stephen Hemminger
2018-06-06 21:30 ` Michael S. Tsirkin
2018-06-06 22:21 ` Stephen Hemminger
2018-06-11 18:07 ` Michael S. Tsirkin
2018-06-06 12:19 ` Michael S. Tsirkin
2018-06-06 21:17 ` Stephen Hemminger
2018-06-06 7:25 ` Jiri Pirko
2018-06-06 12:30 ` Michael S. Tsirkin
2018-06-06 21:24 ` Stephen Hemminger
2018-06-06 21:47 ` Michael S. Tsirkin
2018-06-06 22:24 ` Stephen Hemminger
2018-06-07 14:57 ` Michael S. Tsirkin
2018-06-07 15:23 ` Stephen Hemminger
2018-06-06 21:54 ` Samudrala, Sridhar
2018-06-06 22:25 ` Stephen Hemminger
2018-06-07 14:17 ` Alexander Duyck
2018-06-07 14:51 ` Stephen Hemminger
2018-06-07 15:41 ` Michael S. Tsirkin
2018-06-07 16:17 ` Stephen Hemminger
2018-06-07 17:22 ` Michael S. Tsirkin
2018-06-08 18:30 ` Stephen Hemminger
2018-06-08 19:04 ` Michael S. Tsirkin
2018-06-08 22:54 ` Siwei Liu
2018-06-11 15:17 ` Stephen Hemminger
2018-06-08 22:25 ` Siwei Liu
2018-06-08 23:18 ` Stephen Hemminger
2018-06-08 23:44 ` Siwei Liu
2018-06-09 0:02 ` Stephen Hemminger
2018-06-09 0:42 ` Siwei Liu
2018-06-11 15:22 ` Stephen Hemminger
2018-06-11 19:23 ` Siwei Liu
2018-06-11 14:01 ` Michael S. Tsirkin
2018-06-09 1:29 ` Jakub Kicinski
2018-06-11 18:56 ` Siwei Liu
2018-06-12 2:14 ` Michael S. Tsirkin
2018-06-06 21:26 ` Stephen Hemminger
2018-06-11 18:10 ` Michael S. Tsirkin
2018-06-11 19:34 ` Samudrala, Sridhar
2018-06-12 0:08 ` Samudrala, Sridhar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ffcd7c4-17bf-2e7b-fd48-d61b2a6f2ade@intel.com \
--to=sridhar.samudrala@intel.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.