Re: [dpdk-dev] [PATCH v1 12/18] net/mlx5: separate Rx indirection table object creation

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 9/9/2020 3:37 PM, Matan Azrad wrote:
> 
> Hi Ferruh
> 
> From: Ferruh Yigit
>> On 9/3/2020 11:13 AM, Michael Baum wrote:
>>> Separate Rx indirection table object creation into both Verbs and DevX
>>> modules.
>>>
>>> Signed-off-by: Michael Baum <michaelba@nvidia.com>
>>> Acked-by: Matan Azrad <matan@nvidia.com>
>>
>> <...>
>>
>>> +     if (!ind_tbl->ind_table) {
>>> +             rte_errno = errno;
>>> +             goto error;
>>> +     }
>>> +     rte_atomic32_inc(&ind_tbl->refcnt);
>>>
>>
>> We are switching to c11 atomics, there is a checkpatch warning to higlight this
>> [1], can you please update the rte_atomics... usage to __atomic_... usage?
>> There are multiole usages in other patches too.
>>
> 
> Yes, we saw the warning.
> This code didn't add new atomic, just move code from one location to another.
> We have a plan to move all atomics to c11 atomics later in this release, different task.

I see, OK then.

> 
>> [1]
>> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmails.
>> dpdk.org%2Farchives%2Ftest-report%2F2020-
>> September%2F150684.html&amp;data=02%7C01%7Cmatan%40nvidia.com%
>> 7C055398d1a2cd4f8f0a0f08d854b3a1c8%7C43083d15727340c1b7db39efd9ccc
>> 17a%7C0%7C0%7C637352477778797672&amp;sdata=cqTSn5DQ1AipzbjymFW
>> ZToYDRd%2FjQQHBHWJADXPF7yo%3D&amp;reserved=0