All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Wang" <00107082@163.com>
To: "Greg KH" <gregkh@linuxfoundation.org>,
	mathias.nyman@intel.com, oneukum@suse.com,
	stern@rowland.harvard.edu
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] USB: core: add a memory pool to urb caching host-controller private data
Date: Thu, 22 May 2025 17:47:17 +0800 (CST)	[thread overview]
Message-ID: <2ffd5bed.9108.196f763d60d.Coremail.00107082@163.com> (raw)
In-Reply-To: <2025052257-expectant-macarena-69ee@gregkh>


At 2025-05-22 16:33:42, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>On Thu, May 22, 2025 at 03:09:43PM +0800, David Wang wrote:
>> From an end-user's perspective, the performance difference with this change
>> is insignificant when system is under no memory pressure, and when under
>> heavy memory pressure. When system is under heavy memory pressure,
>> everything is slow.  There could be a point in-between no memory pressure
>> and heavy memory pressure where these 1k+/s memory allocations would
>> dominate the performance, but very hard to pinpoint it.
>
>For this reason alone I can't take this change, sorry.

Still, reasonable to me....
>
>Also, as others have stated, this could be done in the hcd drivers
>themselves if they want to, no need to push this into the usb core.


>
>thanks,
>
>greg k-h


Thanks all you guys for taking time reviewing/discussing this.

David

      reply	other threads:[~2025-05-22  9:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22  7:09 [PATCH v4 1/2] USB: core: add a memory pool to urb caching host-controller private data David Wang
2025-05-22  7:10 ` [PATCH v4 2/2] USB: xhci: use urb hcpriv mempool for " David Wang
2025-05-22  8:32   ` Greg KH
2025-05-22  9:56     ` David Wang
2025-05-22  8:33 ` [PATCH v4 1/2] USB: core: add a memory pool to urb caching host-controller " Greg KH
2025-05-22  9:47   ` David Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ffd5bed.9108.196f763d60d.Coremail.00107082@163.com \
    --to=00107082@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=oneukum@suse.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.