From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-arm@nongnu.org,
"Philippe Mathieu-Daudé " <philmd@linaro.org>,
qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>, "Fam Zheng" <fam@euphon.net>,
qemu-arm@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-block@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Philippe Mathieu-Daudé " <philmd@linaro.org>
Subject: Re: [PATCH 3/7] hw/display/virtio-gpu: Use VIRTIO_DEVICE() macro
Date: Tue, 17 Oct 2023 20:19:22 +0300 [thread overview]
Message-ID: <2oo4t.qv8sufbzi8x0@linaro.org> (raw)
In-Reply-To: <20231017140150.44995-4-philmd@linaro.org>
On Tue, 17 Oct 2023 17:01, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>Access QOM parent with the proper QOM VIRTIO_DEVICE() macro.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>---
> hw/display/virtio-gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
>index 93857ad523..51cb517999 100644
>--- a/hw/display/virtio-gpu.c
>+++ b/hw/display/virtio-gpu.c
>@@ -1132,7 +1132,7 @@ static void virtio_gpu_ctrl_bh(void *opaque)
> VirtIOGPU *g = opaque;
> VirtIOGPUClass *vgc = VIRTIO_GPU_GET_CLASS(g);
>
>- vgc->handle_ctrl(&g->parent_obj.parent_obj, g->ctrl_vq);
>+ vgc->handle_ctrl(VIRTIO_DEVICE(g), g->ctrl_vq);
> }
>
> static void virtio_gpu_handle_cursor(VirtIODevice *vdev, VirtQueue *vq)
>--
>2.41.0
>
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
next prev parent reply other threads:[~2023-10-17 17:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 14:01 [PATCH 0/7] hw: Few more QOM/QDev cleanups Philippe Mathieu-Daudé
2023-10-17 14:01 ` [PATCH 1/7] hw/virtio/virtio-pmem: Replace impossible check by assertion Philippe Mathieu-Daudé
2023-10-17 17:20 ` Manos Pitsidianakis
2023-10-17 14:01 ` [PATCH 2/7] hw/block/vhost-user-blk: Use DEVICE() / VIRTIO_DEVICE() macros Philippe Mathieu-Daudé
2023-10-17 17:15 ` Manos Pitsidianakis
2023-10-17 20:09 ` Mark Cave-Ayland
2023-10-17 14:01 ` [PATCH 3/7] hw/display/virtio-gpu: Use VIRTIO_DEVICE() macro Philippe Mathieu-Daudé
2023-10-17 17:19 ` Manos Pitsidianakis [this message]
2023-10-17 20:10 ` Mark Cave-Ayland
2023-10-17 14:01 ` [PATCH 4/7] hw/scsi/virtio-scsi: Use VIRTIO_SCSI_COMMON() macro Philippe Mathieu-Daudé
2023-10-17 17:19 ` Manos Pitsidianakis
2023-10-17 20:13 ` Mark Cave-Ayland
2023-10-31 13:17 ` Kevin Wolf
2023-10-31 13:21 ` Peter Maydell
2023-10-31 13:48 ` Richard W.M. Jones
2023-10-31 16:35 ` Kevin Wolf
2023-10-31 16:42 ` Kevin Wolf
2023-10-31 16:48 ` Richard W.M. Jones
2023-10-17 14:01 ` [PATCH 5/7] hw/dma: Declare link using static DEFINE_PROP_LINK() macro Philippe Mathieu-Daudé
2023-10-17 20:16 ` Mark Cave-Ayland
2023-10-17 14:01 ` [PATCH 6/7] hw/net: " Philippe Mathieu-Daudé
2023-10-17 20:17 ` Mark Cave-Ayland
2023-10-17 14:01 ` [PATCH 7/7] hw/usb: " Philippe Mathieu-Daudé
2023-10-17 20:19 ` Mark Cave-Ayland
2023-10-17 14:09 ` [PATCH 0/7] hw: Few more QOM/QDev cleanups Michael S. Tsirkin
2023-10-19 21:41 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2oo4t.qv8sufbzi8x0@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.