From: Pratyush Yadav <pratyush@kernel.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Michal Clapinski <mclapinski@google.com>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memblock tests: define MIGRATE_CMA
Date: Mon, 04 May 2026 14:31:06 +0200 [thread overview]
Message-ID: <2vxz8q9z2w6t.fsf@kernel.org> (raw)
In-Reply-To: <CA+CK2bChn3bAFBnmD-fNw2zh-JrAaA73DNmm416EbjXr=mTakA@mail.gmail.com> (Pasha Tatashin's message of "Mon, 4 May 2026 06:32:11 -0400")
On Mon, May 04 2026, Pasha Tatashin wrote:
> On Mon, May 4, 2026 at 6:27 AM Pratyush Yadav <pratyush@kernel.org> wrote:
>>
>> From: "Pratyush Yadav (Google)" <pratyush@kernel.org>
>>
>> kho_scratch_migratetype(), defined in include/linux/memblock.h uses enum
>> migratetype. This breaks build for memblock tests with:
>>
>> ./linux/memblock.h:634:73: error: parameter 2 (‘mt’) has incomplete type
>> 634 | enum migratetype mt)
>>
>> Fix it by defining enum migratetype and MIGRATE_CMA. As is the case with
>> the other headers in tools/testing/memblock, do not bring in the whole
>> thing, only what is needed.
>>
>> Reported-by: Mike Rapoport <rppt@kernel.org>
>> Closes: https://lore.kernel.org/linux-mm/afcdDm4aAJvNaQqH@kernel.org/
>
> Link does not open for me.
Dunno why. Works fine for me... Maybe some temporary issue with lore?
[...]
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2026-05-04 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 10:27 [PATCH] memblock tests: define MIGRATE_CMA Pratyush Yadav
2026-05-04 10:32 ` Pasha Tatashin
2026-05-04 12:31 ` Pratyush Yadav [this message]
2026-05-04 12:33 ` Pratyush Yadav
2026-05-04 13:46 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxz8q9z2w6t.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mclapinski@google.com \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.