All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
	 pasha.tatashin@soleen.com, pratyush@kernel.org,
	 linux-kernel@vger.kernel.org,  surenb@google.com
Subject: Re: [PATCH] kexec: allow KEXEC_HANDOVER to build with COMPILE_TEST
Date: Thu, 05 Feb 2026 13:07:36 +0100	[thread overview]
Message-ID: <2vxz8qd7z94n.fsf@kernel.org> (raw)
In-Reply-To: <aYSGQOrYRa9obgST@kernel.org> (Mike Rapoport's message of "Thu, 5 Feb 2026 14:00:00 +0200")

On Thu, Feb 05 2026, Mike Rapoport wrote:

> On Wed, Feb 04, 2026 at 01:28:16PM -0500, Sasha Levin wrote:
>> Currently allmodconfig sets CONFIG_DEFERRED_STRUCT_PAGE_INIT which prevents KHO
>> from building.
>> 
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>>  kernel/liveupdate/Kconfig | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/kernel/liveupdate/Kconfig b/kernel/liveupdate/Kconfig
>> index d2aeaf13c3acb..355b43492b8a4 100644
>> --- a/kernel/liveupdate/Kconfig
>> +++ b/kernel/liveupdate/Kconfig
>> @@ -1,14 +1,14 @@
>>  # SPDX-License-Identifier: GPL-2.0-only
>>  
>>  menu "Live Update and Kexec HandOver"
>> -	depends on !DEFERRED_STRUCT_PAGE_INIT
>> +	depends on !DEFERRED_STRUCT_PAGE_INIT || COMPILE_TEST
>>  
>>  config KEXEC_HANDOVER
>>  	bool "kexec handover"
>> -	depends on ARCH_SUPPORTS_KEXEC_HANDOVER && ARCH_SUPPORTS_KEXEC_FILE
>> -	depends on !DEFERRED_STRUCT_PAGE_INIT
>> +	depends on (ARCH_SUPPORTS_KEXEC_HANDOVER && ARCH_SUPPORTS_KEXEC_FILE) || COMPILE_TEST
>
> I don't think we want to build this for all architectures.
> Let's keep depends on ARCH_ as it was.

Yep. All these test robot warnings are because a bunch of KHO/LUO code
assumes 64-bit arch.

>
>> +	depends on !DEFERRED_STRUCT_PAGE_INIT || COMPILE_TEST
>>  	select MEMBLOCK_KHO_SCRATCH
>> -	select KEXEC_FILE
>> +	select KEXEC_FILE if ARCH_SUPPORTS_KEXEC_FILE

If arch does not support kexec_file we can't use KHO at all anyway. So I
am not sure if this makes sense.

>>  	select LIBFDT
>>  	select CMA
>>  	help
>> -- 
>> 2.51.0
>> 

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2026-02-05 12:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 18:28 [PATCH] kexec: allow KEXEC_HANDOVER to build with COMPILE_TEST Sasha Levin
2026-02-04 22:32 ` Suren Baghdasaryan
2026-02-05  0:22 ` kernel test robot
2026-02-05  2:05 ` kernel test robot
2026-02-05  2:05 ` kernel test robot
2026-02-05 12:00 ` Mike Rapoport
2026-02-05 12:07   ` Pratyush Yadav [this message]
2026-02-05 12:05 ` kernel test robot
2026-02-06 21:52 ` [PATCH v2] " Sasha Levin
2026-02-07  7:40   ` Mike Rapoport
2026-02-07 16:06   ` Pasha Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2vxz8qd7z94n.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=rppt@kernel.org \
    --cc=sashal@kernel.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.