From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43EC53A59A3 for ; Tue, 16 Jun 2026 11:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781610938; cv=none; b=C8bjEZ34ZmswemcggZv/XjONZ92VaTrBMGhSUiMr9ZKOMTO9CeJdl3l3ZH9smWQIiwzKHuh23oyAo3V2hremLPOw9bM7/fjmFo1flzdfegv3L8r4yn0rkEfz4mEjGoK4G/uimeigQQYmN1L5t2VpEY3S1UuGwD0ogctv0mugw4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781610938; c=relaxed/simple; bh=wKnS+87CM3PY6xD8cSAEI74LkCA5m75lKhEZsBtpLVA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=q/vTL7hxtjhO8EuoDCgQLhza135NuVfQwTA/sJV49qkvGqjxdewisBITXjwUee8kg6SzT3oQhOEj11E+nzti/MAy1HQxVCGt9idZwK2IdMrRIlCBZCqc2a9iC5XiJZYwpMNnrVZGEsf9KlyP7j7/1X44mvGOMGI7AVOIxkeV5IM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iffZFXdP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iffZFXdP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E908E1F000E9; Tue, 16 Jun 2026 11:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781610936; bh=PVrkjTNsI/ijcmHUN41Jsl0b0/mRiz+GKrYsk7fPAnU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=iffZFXdPsqffUhK6CzGmq+YjTsVs6JW1/9oH/iS48OsaYOORC+kle/vWS9+/XW6Cb E8kukeHIZlFbBOeI+eoS9R0ASMC8+jY6EF87SEzoKAvZgoR0YBFVcLeRbdRkKHFOvi EMP+T7acLndMaIgC0bwEOFsIu8J5FjC5z8ZEE8Y2w8GWqBVMOHcnRoSRnR1MUD+Aiq fcwwOLizFw/MyK2eJWHufryllI6i59A16S9lmFL08DMF5yFxUEnphhdjcjNl3OJinw 63Hwi/Kpi/ab+lIiZUAcXaJqMs4rjFmywr/g6WmNJEauIRtEMi4fuC1ehJ6uSQmDCw TUUoqzxJY+VRQ== From: Pratyush Yadav To: Mike Rapoport Cc: Pratyush Yadav , Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , Jork Loeser , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 15/18] kho: extend scratch In-Reply-To: (Mike Rapoport's message of "Mon, 15 Jun 2026 22:37:36 +0300") References: <20260605183501.3884950-1-pratyush@kernel.org> <20260605183501.3884950-16-pratyush@kernel.org> <178143855117.2123877.6330314807920146675.b4-review@b4> <2vxztsr4orvg.fsf@kernel.org> Date: Tue, 16 Jun 2026 13:55:33 +0200 Message-ID: <2vxza4supumi.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Jun 15 2026, Mike Rapoport wrote: > On Mon, Jun 15, 2026 at 03:28:03PM +0200, Pratyush Yadav wrote: >> On Sun, Jun 14 2026, Mike Rapoport wrote: >> > On Fri, 05 Jun 2026 20:34:48 +0200, Pratyush Yadav wrote: >> > >> >> +{ >> >> + struct kho_radix_tree *tree = data; >> > >> > Would be nice to say which tree in the variable name ;) >> >> How about preserved_mem_map? > > But this is the new tree, isn't it? > Maybe keep the variable name and add a comment? Oh, right. The fact that I didn't remember it certainly means a comment is needed. Will add. [...] -- Regards, Pratyush Yadav