From: Pratyush Yadav <pratyush@kernel.org>
To: George Guo <dongtai.guo@linux.dev>
Cc: chenhuacai@kernel.org, ardb@kernel.org, pratyush@kernel.org,
rppt@kernel.org, pasha.tatashin@soleen.com, shuah@kernel.org,
ilias.apalodimas@linaro.org, akpm@linux-foundation.org,
baoquan.he@linux.dev, ruirui.yang@linux.dev,
guodongtai@kylinos.cn, kernel@xen0n.name, graf@amazon.com,
liukexin@kylinos.cn, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-efi@vger.kernel.org
Subject: Re: [PATCH v6 1/8] efi: Pass KHO state to the next kernel in a configuration table
Date: Thu, 19 Nov 2026 10:58:11 +0000 [thread overview]
Message-ID: <2vxzecch3x6k.fsf@kernel.org> (raw)
In-Reply-To: <20261119082252.9120-1-dongtai.guo@linux.dev> (George Guo's message of "Thu, 19 Nov 2026 17:22:52 +0900")
On Thu, Nov 19 2026, George Guo wrote:
> Hi Huacai, Ard, Pratyush,
>
> On Wed, Nov 04 2026, Huacai Chen wrote:
>> I prefer to keep it in LoongArch until a second architecture, and I
>> think Ard is the same. But this is not a strong objection to Pratyush.
>
> Kexin Liu and I have tried x86 as the second user, to see whether the
> common table holds up. It needed only small changes:
>
> - The x86 EFI stub installs the table, as the LoongArch stub does.
> install_kho_table() moves from efi-stub.c to efi-stub-helper.c so
> that the x86 stub can call it.
>
> - kexec_file_load() skips the SETUP_KEXEC_KHO record when the table
> exists and the next kernel will get efi_info. Otherwise, for example
> on a legacy BIOS boot or with noefi, it falls back to setup_data.
Do we even care about non-EFI boot? I'd say ignore that for now until
someone comes with a real use case for KHO on such systems.
>
> - When there is no SETUP_KEXEC_KHO record, the decompressor's KASLR
> code looks up the KHO bootmem areas in the table, so the kernel is
> not decompressed onto preserved memory.
>
> The table layout did not change. The only change to the common code is
> that efi_kho_table_found() is no longer __init, since x86 calls it at
> kexec load time.
>
> Tested in QEMU on x86_64. With OVMF, the KHO vmtest and
> luo_kexec_simple pass, and the second kernel finds the KHO state
> through the table. With SeaBIOS, the KHO vmtest passes through
> setup_data.
>
> So I would like to keep the table common in v7. Would you prefer the
> x86 patches in the same series, so that the generic code comes with a
> second user, or as a separate series on top?
This should be a follow up series. Don't get your series get caught up
in x86 changes.
>
> Pratyush, does this match what you had in mind for x86?
Sounds good to me. You will still need to chase Ard for an ACK on the
generic EFI table though.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2026-11-19 10:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 17:29 [PATCH v6 0/8] LoongArch: Add KHO support and selftests George Guo
2026-10-29 17:29 ` [PATCH v6 1/8] efi: Pass KHO state to the next kernel in a configuration table George Guo
2026-10-29 17:47 ` sashiko-bot
2026-10-29 19:28 ` Ard Biesheuvel
2026-10-29 19:42 ` Pratyush Yadav
2026-11-03 10:29 ` George Guo
2026-11-04 3:59 ` Huacai Chen
2026-11-19 8:22 ` George Guo
2026-11-19 10:58 ` Pratyush Yadav [this message]
2026-11-19 12:36 ` George Guo
2026-11-04 14:54 ` Mukesh Pilaniya
2026-10-29 17:29 ` [PATCH v6 2/8] kho: Write KHO state to the EFI table at kexec time George Guo
2026-10-29 17:47 ` sashiko-bot
2026-10-29 17:29 ` [PATCH v6 3/8] kho: Include linux/mm.h in kho_block.c George Guo
2026-10-29 17:47 ` sashiko-bot
2026-11-20 8:20 ` Huacai Chen
2026-10-29 17:29 ` [PATCH v6 4/8] kho: Add kho_disable() George Guo
2026-10-29 17:47 ` sashiko-bot
2026-11-05 12:53 ` Mike Rapoport
2026-10-29 17:29 ` [PATCH v6 5/8] LoongArch: Allow memblock arrays to resize George Guo
2026-10-29 17:47 ` sashiko-bot
2026-11-05 12:57 ` Mike Rapoport
2026-11-05 15:07 ` Huacai Chen
2026-11-05 16:07 ` Mike Rapoport
2026-11-06 14:35 ` Huacai Chen
2026-11-08 8:14 ` Mike Rapoport
2026-11-08 8:26 ` Huacai Chen
2026-10-29 17:29 ` [PATCH v6 6/8] LoongArch: Enable kexec handover (KHO) George Guo
2026-10-29 17:47 ` sashiko-bot
2026-10-29 17:29 ` [PATCH v6 7/8] selftests/kho: Add LoongArch vmtest support George Guo
2026-10-29 17:47 ` sashiko-bot
2026-10-29 17:29 ` [PATCH v6 8/8] selftests/liveupdate: " George Guo
2026-10-29 17:47 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzecch3x6k.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=chenhuacai@kernel.org \
--cc=dongtai.guo@linux.dev \
--cc=graf@amazon.com \
--cc=guodongtai@kylinos.cn \
--cc=ilias.apalodimas@linaro.org \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liukexin@kylinos.cn \
--cc=loongarch@lists.linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=ruirui.yang@linux.dev \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.