From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] eal: prefix telemetry initialization message
Date: Thu, 25 Mar 2021 15:32:27 +0100 [thread overview]
Message-ID: <30013763.OcDqWryzec@thomas> (raw)
In-Reply-To: <20210309140355.GA1141@bricha3-MOBL.ger.corp.intel.com>
09/03/2021 15:03, Bruce Richardson:
> On Tue, Mar 09, 2021 at 10:59:52AM +0000, Bruce Richardson wrote:
> > On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote:
> > > If the telemetry library initialization has some issue,
> > > the error message is returned in a string
> > > (to avoid circular dependency with EAL log system).
> > >
> > > In order to make clear where the message comes from,
> > > a prefix is added.
> > > Before: EAL: message
> > > After: EAL: telemetry: message
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> By the way, I have a nearly completed patch for the telemetry library to
> switch it to doing its own logging instead of passing back a string. It
> does require a function pointer to rte_log to be passed to the init call,
> but thereafter things are pretty normal in it and simplifies things. I'll
> send it on as soon as it is ready.
Thank you for the rework.
This patch is now classified as "Superseded".
prev parent reply other threads:[~2021-03-25 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 22:23 [dpdk-dev] [PATCH] eal: prefix telemetry initialization message Thomas Monjalon
2021-03-09 10:59 ` Bruce Richardson
2021-03-09 14:03 ` Bruce Richardson
2021-03-25 14:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30013763.OcDqWryzec@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.