From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/1] drm: gem_cma: Use ERR_CAST helper
Date: Thu, 29 May 2014 16:00:37 +0200
Message-ID: <3002835.ly8JuaRppI@avalon>
References: <1401337998-18085-1-git-send-email-sachin.kamat@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
 [95.142.166.194])
 by gabe.freedesktop.org (Postfix) with ESMTP id 541846E9B4
 for <dri-devel@lists.freedesktop.org>; Thu, 29 May 2014 07:00:18 -0700 (PDT)
In-Reply-To: <1401337998-18085-1-git-send-email-sachin.kamat@linaro.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Sachin,

Thank you for the patch.

On Thursday 29 May 2014 10:03:18 Sachin Kamat wrote:
> Makes the code a bit more readable.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_gem_cma_helper.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
> b/drivers/gpu/drm/drm_gem_cma_helper.c index 05c97c5350a1..e467e67af6e7
> 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -327,7 +327,7 @@ drm_gem_cma_prime_import_sg_table(struct drm_device
> *dev, size_t size, /* Create a CMA GEM buffer. */
>  	cma_obj = __drm_gem_cma_create(dev, size);
>  	if (IS_ERR(cma_obj))
> -		return ERR_PTR(PTR_ERR(cma_obj));
> +		return ERR_CAST(cma_obj);
> 
>  	cma_obj->paddr = sg_dma_address(sgt->sgl);
>  	cma_obj->sgt = sgt;

-- 
Regards,

Laurent Pinchart