All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Rongqiang XIE <xie.rongqiang@zte.com.cn>
Cc: dev@dpdk.org, "Gaëtan Rivet" <gaetan.rivet@6wind.com>,
	bruce.richardson@intel.com
Subject: Re: [PATCH] lib/lib_eal:add mellanox kernel driver type
Date: Mon, 09 Oct 2017 19:27:39 +0200	[thread overview]
Message-ID: <3002950.9ou733SsWm@xps> (raw)
In-Reply-To: <20170823080424.GY8124@bidouze.vm.6wind.com>

23/08/2017 10:04, Gaëtan Rivet:
> Hi,
> 
> On Wed, Aug 23, 2017 at 10:48:01AM +0800, Rongqiang XIE wrote:
> > When use bond function in mellanox driver environment, we call the
> > find_port_id_by_pci_addr() function,if we don't add mellanox kernel
> > driver type in enum rte_kernel_driver, the function will return -1
> > because kdrv unknown, so we add the mellanox driver type, and when
> > scan the pci, fill the kdrv to fix this problem.
> > 
> 
> The issue is not that MLX devices are not properly represented, but
> that the find_port_id_by_pci_addr function has a crappy way to recognize
> PCI devices.
> 
> The find_device bus operator should be used to find a device having
> a specific rte_pci_addr. I described something similar not too long
> ago[1]. This matching function would benefit from being properly
> rewritten.
> 
> [1]: http://dpdk.org/ml/archives/dev/2017-July/072172.html
> 
> > Signed-off-by: Rongqiang XIE <xie.rongqiang@zte.com.cn>

This issue has been fixed as a result of the thread which
Gaetan is referencing:
	http://dpdk.org/browse/dpdk/commit/?id=c848b518bb

  reply	other threads:[~2017-10-09 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  2:48 [PATCH] lib/lib_eal:add mellanox kernel driver type Rongqiang XIE
2017-08-23  8:04 ` Gaëtan Rivet
2017-10-09 17:27   ` Thomas Monjalon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-23  1:57 Rongqiang XIE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3002950.9ou733SsWm@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=xie.rongqiang@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.