From: Thomas Monjalon <thomas@monjalon.net>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [PATCH v3] pdump: fix vdev cleanup
Date: Tue, 15 Jan 2019 01:59:18 +0100 [thread overview]
Message-ID: <3007842.nGy45PVQPd@xps> (raw)
In-Reply-To: <20190111175134.40273-1-reshma.pattan@intel.com>
11/01/2019 18:51, Reshma Pattan:
> Virtual devices added in pdump application
> using rte_eal_hotplug_add should be removed explicitly
> while existing the pdump application, otherwise the
existing -> exiting ?
> subsequent run of the pdump application will fail with the reason
> that virtual devices with the same name already exists in primary.
>
> Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev attach")
> CC: stable@dpdk.org
> CC: ferruh.yigit@intel.com
Why is it marked as a fix of this commit?
Is it a miss in the conversion from ethdev attach calls?
Or a changed behaviour with hotplug functions?
next prev parent reply other threads:[~2019-01-15 0:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 17:41 [PATCH v2] pdump: fix vdev cleanup Reshma Pattan
2019-01-11 17:51 ` [PATCH v3] " Reshma Pattan
2019-01-15 0:59 ` Thomas Monjalon [this message]
2019-01-15 10:09 ` Pattan, Reshma
2019-01-15 10:10 ` Thomas Monjalon
2019-01-15 10:25 ` Pattan, Reshma
2019-01-17 20:23 ` Thomas Monjalon
2019-01-15 13:45 ` [PATCH v4] " Reshma Pattan
2019-01-15 14:57 ` Ferruh Yigit
2019-01-17 20:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3007842.nGy45PVQPd@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.