From: Thomas Monjalon <thomas@monjalon.net>
To: Yuanhan Liu <yliu@fridaylinux.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Jacek Piasecki <jacekx.piasecki@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, michalx.k.jastrzebski@intel.com,
changpeng.liu@intel.com
Subject: Re: [dpdk-stable] [PATCH v3] examples/vhost_scsi: fix buffer not terminated
Date: Tue, 24 Oct 2017 18:22:43 +0200 [thread overview]
Message-ID: <3010275.oDysHLUK20@xps> (raw)
In-Reply-To: <20171017132637.GY1545@yliu-home>
17/10/2017 15:26, Yuanhan Liu:
> On Fri, Oct 13, 2017 at 09:12:33AM +0200, Maxime Coquelin wrote:
> > On 10/12/2017 01:34 PM, Jacek Piasecki wrote:
> > >--- a/examples/vhost_scsi/scsi.c
> > >+++ b/examples/vhost_scsi/scsi.c
> > >@@ -307,7 +307,9 @@ vhost_bdev_scsi_inquiry_command(struct vhost_block_dev *bdev,
> > > strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8);
> > > /* PRODUCT IDENTIFICATION */
> > >- strncpy((char *)inqdata->product_id, bdev->product_name, 16);
> > >+ snprintf((char *)inqdata->product_id,
> > >+ ARRAY_SIZE(inqdata->product_id), "%s",
> > >+ bdev->product_name);
> > > /* PRODUCT REVISION LEVEL */
> > > strncpy((char *)inqdata->product_rev, "0001", 4);
> >
> > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Firstly, sorry for being so late response. And,
>
> Applied to dpdk-next-virtio. Thanks!
I don't know where this ARRAY_SIZE comes from.
It does not compile.
In DPDK you can use RTE_DIM.
This patch is removed from the next-virtio pull queue.
next prev parent reply other threads:[~2017-10-24 16:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 13:07 [PATCH] examples/vhost_scsi: fix buffer not terminated Michal Jastrzebski
2017-10-02 13:50 ` Jastrzebski, MichalX K
2017-10-02 15:07 ` Maxime Coquelin
2017-10-05 12:35 ` Piasecki, JacekX
2017-10-05 12:42 ` Maxime Coquelin
2017-10-05 13:01 ` Bruce Richardson
2017-10-05 13:02 ` Maxime Coquelin
2017-10-12 6:44 ` [PATCH v2] " Jacek Piasecki
2017-10-12 11:09 ` Maxime Coquelin
2017-10-12 11:34 ` [PATCH v3] " Jacek Piasecki
2017-10-13 7:12 ` Maxime Coquelin
2017-10-17 13:26 ` Yuanhan Liu
2017-10-24 16:22 ` Thomas Monjalon [this message]
2017-10-25 10:07 ` [PATCH v4] " Jacek Piasecki
2017-10-25 10:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3010275.oDysHLUK20@xps \
--to=thomas@monjalon.net \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=jacekx.piasecki@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.