From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: kbuild test robot <fengguang.wu@intel.com>,
Antonio Quartulli <a@unstable.cc>,
kbuild-all@01.org, Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings
Date: Wed, 06 Jul 2016 09:26:15 +0200 [thread overview]
Message-ID: <3018169.ulU2hFjq7O@bentobox> (raw)
In-Reply-To: <1937144.keiqMBNOt5@sven-edge>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Wednesday 06 July 2016 08:12:09 Sven Eckelmann wrote:
> On Wednesday 06 July 2016 10:49:29 kbuild test robot wrote:
> > net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool
> >
> > Return statements in functions returning bool should use
> > true/false instead of 1/0.
> > Generated by: scripts/coccinelle/misc/boolreturn.cocci
> >
> > CC: Sven Eckelmann <sven@narfation.org>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
>
> Reviewed-by: Sven Eckelmann <sven@narfation.org>
>
> The problematic commit is in batman-adv.git (next):
>
> Fixes: a998bf5dfbd7 ("batman-adv: add detection for complex bridge loops")
Sorry, I meant maint and not next. It was already part of v2016.2
@Marek not sure where you want to apply it. It should have no effect
on the actual functionality.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-06 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 2:49 net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool kbuild test robot
2016-07-06 2:49 ` [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot
2016-07-06 2:49 ` kbuild test robot
2016-07-06 6:12 ` [B.A.T.M.A.N.] " Sven Eckelmann
2016-07-06 7:26 ` Sven Eckelmann [this message]
2016-07-06 13:44 ` Marek Lindner
2016-07-06 13:44 ` Marek Lindner
2016-07-06 13:44 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3018169.ulU2hFjq7O@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.