All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"jerinj@marvell.com" <jerinj@marvell.com>,
	 "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
	"Yan, Zhirun" <zhirun.yan@intel.com>
Subject: Re: [PATCH v2] graph: fix head move when graph walk in mcore dispatch
Date: Thu, 27 Jun 2024 15:52:21 +0200	[thread overview]
Message-ID: <3019171.aBcLfjPe96@thomas> (raw)
In-Reply-To: <SN7PR11MB6775B337030A1DCDA55375F7853B2@SN7PR11MB6775.namprd11.prod.outlook.com>

28/03/2024 09:32, Yan, Zhirun:
> From: Wu, Jingjing <jingjing.wu@intel.com>
> > --- a/lib/graph/rte_graph_model_mcore_dispatch.h
> > +++ b/lib/graph/rte_graph_model_mcore_dispatch.h
> > @@ -100,9 +100,8 @@ rte_graph_walk_mcore_dispatch(struct rte_graph
> > *graph)
> >  		node = (struct rte_node *)RTE_PTR_ADD(graph,
> > cir_start[(int32_t)head++]);
> > 
> >  		/* skip the src nodes which not bind with current worker */
> > -		if ((int32_t)head < 0 && node->dispatch.lcore_id != graph-
> > >dispatch.lcore_id)
> > +		if ((int32_t)head < 1 && node->dispatch.lcore_id !=
> > +graph->dispatch.lcore_id)
> >  			continue;
> > -
> No need for this line.
> 
> >  		/* Schedule the node until all task/objs are done */
> >  		if (node->dispatch.lcore_id != RTE_MAX_LCORE &&
> >  		    graph->dispatch.lcore_id != node->dispatch.lcore_id &&
> > --
> > 2.34.1
> 
> With small change,
> 
> Acked-by: Zhirun Yan <zhirun.yan@intel.com>

Applied with above change, thanks.



      reply	other threads:[~2024-06-27 13:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 14:14 [PATCH] graph: fix head move when graph walk in mcore dispatch Jingjing Wu
2024-03-20  3:33 ` Yan, Zhirun
2024-03-20  6:25   ` Wu, Jingjing
2024-03-20  8:42     ` Yan, Zhirun
2024-03-21  3:39       ` Wu, Jingjing
2024-03-21  5:34         ` Yan, Zhirun
2024-03-22 15:46 ` [PATCH v2] " Jingjing Wu
2024-03-28  8:32   ` Yan, Zhirun
2024-06-27 13:52     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3019171.aBcLfjPe96@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=jingjing.wu@intel.com \
    --cc=pbhagavatula@marvell.com \
    --cc=zhirun.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.