From: Jonathan Toppins <jtoppins@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>
Subject: Re: [PATCH net 2/3] selftests: bonding: re-format bond option tests
Date: Thu, 30 Mar 2023 12:45:11 -0400 [thread overview]
Message-ID: <301d2861-1390-eaea-4521-90d4dcfe7336@redhat.com> (raw)
In-Reply-To: <20230329101859.3458449-3-liuhangbin@gmail.com>
On 3/29/23 06:18, Hangbin Liu wrote:
> To improve the testing process for bond options, A new bond library is
> added to our testing setup. The current option_prio.sh file will be
> renamed to bond_options.sh so that all bonding options can be tested here.
> Specifically, for priority testing, we will run all tests using module
I think you mean `modes`^^^
> 1, 5, and 6. These changes will help us streamline the testing process
> and ensure that our bond options are rigorously evaluated.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> .../selftests/drivers/net/bonding/Makefile | 3 +-
> .../selftests/drivers/net/bonding/bond_lib.sh | 145 +++++++++++
> .../drivers/net/bonding/bond_options.sh | 216 +++++++++++++++
> .../drivers/net/bonding/option_prio.sh | 245 ------------------
> 4 files changed, 363 insertions(+), 246 deletions(-)
> create mode 100644 tools/testing/selftests/drivers/net/bonding/bond_lib.sh
> create mode 100755 tools/testing/selftests/drivers/net/bonding/bond_options.sh
> delete mode 100755 tools/testing/selftests/drivers/net/bonding/option_prio.sh
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/Makefile b/tools/testing/selftests/drivers/net/bonding/Makefile
> index a39bb2560d9b..4683b06afdba 100644
> --- a/tools/testing/selftests/drivers/net/bonding/Makefile
> +++ b/tools/testing/selftests/drivers/net/bonding/Makefile
> @@ -8,11 +8,12 @@ TEST_PROGS := \
> dev_addr_lists.sh \
> mode-1-recovery-updelay.sh \
> mode-2-recovery-updelay.sh \
> - option_prio.sh \
> + bond_options.sh \
> bond-eth-type-change.sh
>
> TEST_FILES := \
> lag_lib.sh \
> + bond_lib.sh \
> net_forwarding_lib.sh
>
> include ../../../lib.mk
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond_lib.sh b/tools/testing/selftests/drivers/net/bonding/bond_lib.sh
> new file mode 100644
> index 000000000000..ca64a82e1385
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/bonding/bond_lib.sh
I like this idea, we might want to separate network topology from
library code however. That way a given test case can just include a
predefined topology. A quick review of the test cases show a 2 node
setup is the most common across all test cases.
-Jon
next prev parent reply other threads:[~2023-03-30 16:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 10:18 [PATCH net 0/3] bonding: fix ns validation on backup slaves Hangbin Liu
2023-03-29 10:18 ` [PATCH net 1/3] " Hangbin Liu
2023-03-30 16:46 ` Jonathan Toppins
2023-03-31 4:02 ` Jay Vosburgh
2023-03-29 10:18 ` [PATCH net 2/3] selftests: bonding: re-format bond option tests Hangbin Liu
2023-03-30 16:45 ` Jonathan Toppins [this message]
2023-03-31 2:31 ` Hangbin Liu
2023-04-04 2:28 ` Hangbin Liu
2023-04-04 16:34 ` Jonathan Toppins
2023-04-05 9:57 ` Hangbin Liu
2023-04-06 0:23 ` Jonathan Toppins
2023-03-31 3:55 ` Jay Vosburgh
2023-03-29 10:18 ` [PATCH net 3/3] selftests: bonding: add arp validate test Hangbin Liu
2023-03-30 16:48 ` Jonathan Toppins
2023-03-31 4:00 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=301d2861-1390-eaea-4521-90d4dcfe7336@redhat.com \
--to=jtoppins@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.