From: Zhouping Liu <zliu@redhat.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'
Date: Fri, 15 Mar 2013 11:41:29 -0400 (EDT) [thread overview]
Message-ID: <302258505.8905505.1363362089669.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1914766227.19199525.1363338717055.JavaMail.root@redhat.com>
----- Original Message -----
> From: "Jan Stancek" <jstancek@redhat.com>
> To: "Zhouping Liu" <zliu@redhat.com>
> Cc: "LTP List" <ltp-list@lists.sourceforge.net>
> Sent: Friday, March 15, 2013 5:11:57 PM
> Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'
>
>
>
> ----- Original Message -----
> > From: "Zhouping Liu" <zliu@redhat.com>
> > To: "Jan Stancek" <jstancek@redhat.com>
> > Cc: chrubis@suse.cz, "LTP List" <ltp-list@lists.sourceforge.net>
> > Sent: Friday, 15 March, 2013 3:52:26 AM
> > Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET'
> > and updated 'OOM with MEMCG & numa'
>
> > > We could add a simple function to numa_helper, but I'm not sure
> > > what
> > > it would return as default, some tests care about nodes with
> > > memory.
> >
> > yes, what you care about is right, but now we only need a function,
> > which
> > can tell us the system have more than one node, we don't care about
> > the
> > nodes have
> > CPUs or memory.
>
> What I was wondering is why that comment said "rough estimate",
because in the old version, I just used the max node id to judge a NUMA system,
which maybe is not strict.
> it looks quite accurate. Anyway, thanks for clarifying.
in the V2 version, I removed the ISNUMA variable, and added a new function is_numa(),
inside the function, the system, which has 1 more than numa node, and each node at
least contains memory, is regarded as a numa system. I think it's more reasoned,
because NUMA is mainly about memory, more case will fail if the node has no memory.
do you agree?
--
Thanks,
Zhouping
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-03-15 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51428CEA.6030604@redhat.com>
2013-03-15 9:11 ` [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa' Jan Stancek
2013-03-15 15:41 ` Zhouping Liu [this message]
2013-03-15 16:06 ` Jan Stancek
2013-03-14 16:21 [LTP] [PATCH 1/5] lib/mem: modified _gather_cpus() as _gather_node_cpus() Zhouping Liu
2013-03-14 16:21 ` [LTP] [PATCH 2/5] mm/oom02: modified 'OOM for NUMA' as 'OOM for mempolicy' Zhouping Liu
2013-03-14 16:21 ` [LTP] [PATCH 0/5] mm/oom: extend the coverage of OOM Zhouping Liu
2013-03-14 16:21 ` [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa' Zhouping Liu
2013-03-14 16:51 ` chrubis
[not found] ` <507561236.18941341.1363282016883.JavaMail.root@redhat.com>
2013-03-14 18:32 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=302258505.8905505.1363362089669.JavaMail.root@redhat.com \
--to=zliu@redhat.com \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.