From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65009CDB474 for ; Tue, 17 Oct 2023 07:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GORdP/GgNyRsp8HUNw1afwbaEiWARLGy5xjuliSK8nk=; b=F6MYnI3LiZYzIS zIIstnI+KeYY6ET8VsQbJ3XtWT9B9/SMDZ9wVoQ/Uw/h6pNjsNesKMjaoYVY6PyYhP6GixPHM+Sop IzSStB2da6D4eJGnPOMhWujUouv/4QOeiiZuPlRHSGusElhYAZL0XzOwGLXfkJDp/hp1P43lc01Rn z1h5/uXSZY4kxCS52DdXHXCv1EGZbmThLxLE7L3nckvTaNgwmO1NyEfFe+59ezQ5F57pXOZULHn58 m3F/OTOkLpnovYEurdW+Vs7KIvaENoZ/wZMkTJfcjsc5HrusC9vOqf1Mo0sQu34q+01ffiCL0j2pN PEVp3SWfvfvm5GmELcbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsekO-00BaYv-12; Tue, 17 Oct 2023 07:44:12 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsekK-00BaV6-2X for linux-rockchip@lists.infradead.org; Tue, 17 Oct 2023 07:44:10 +0000 Received: from i53875b5b.versanet.de ([83.135.91.91] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsekB-0005qD-9e; Tue, 17 Oct 2023 09:43:59 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Morgan Cc: Chris Morgan , Dragan Simic , Guido =?ISO-8859-1?Q?G=FCnther?= , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, andyshrk@163.com, jagan@edgeble.ai, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, neil.armstrong@linaro.org, megous@megous.com, kernel@puri.sm, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Ondrej Jirman Subject: Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support Date: Tue, 17 Oct 2023 09:43:57 +0200 Message-ID: <3022818.687JKscXgg@diego> In-Reply-To: References: <20231013183918.225666-1-macroalpha82@gmail.com> <2140189.3Lj2Plt8kZ@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_004408_821218_5E39B22D X-CRM114-Status: GOOD ( 30.12 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgQ2hyaXMsCgpBbSBNb250YWcsIDE2LiBPa3RvYmVyIDIwMjMsIDIwOjI2OjU4IENFU1Qgc2No cmllYiBDaHJpcyBNb3JnYW46Cj4gT24gTW9uLCBPY3QgMTYsIDIwMjMgYXQgMDg6MTg6MjVQTSAr MDIwMCwgSGVpa28gU3TDvGJuZXIgd3JvdGU6Cj4gPiBIaSwKPiA+IAo+ID4gQW0gTW9udGFnLCAx Ni4gT2t0b2JlciAyMDIzLCAxODowNzo1MiBDRVNUIHNjaHJpZWIgRHJhZ2FuIFNpbWljOgo+ID4g PiBPbiAyMDIzLTEwLTE2IDE3OjUyLCBDaHJpcyBNb3JnYW4gd3JvdGU6Cj4gPiA+ID4gQ29uZmly bWVkIHRoYXQgdGhvc2UgcGVuZGluZyBwYXRjaGVzIERPIGZpeCB0aGUgcGFuZWwgc3VzcGVuZCBp c3N1ZXMuIAo+ID4gPiA+IFRoYW5rIHlvdS4KPiA+ID4gCj4gPiA+IEF3ZXNvbWUsIHRoYXQncyBn cmVhdCB0byBoZWFyISAgUGVyaGFwcyBhICJUZXN0ZWQtYnkiIGluIHRoZSBvcmlnaW5hbCAKPiA+ ID4gTEtNTCB0aHJlYWQgWzFdIGNvdWxkIGhlbHAgd2l0aCBoYXZpbmcgdGhlIHBhdGNoIHB1bGxl ZCBzb29uZXIuCj4gPiA+IAo+ID4gPiBMaW5rczoKPiA+ID4gWzFdIAo+ID4gPiBodHRwczovL2xv cmUua2VybmVsLm9yZy9sa21sLzMzYjcyOTU3LTEwNjItMWI2Ni04NWViLWMzN2RjNWNhMjU5YkBy ZWRoYXQuY29tL1QvCj4gPiA+IAo+ID4gPiAKPiA+ID4gPiBPbiBNb24sIE9jdCAxNiwgMjAyMyBh dCAzOjQx4oCvQU0gR3VpZG8gR8O8bnRoZXIgPGd1aWRvLmd1bnRoZXJAcHVyaS5zbT4gCj4gPiA+ ID4gd3JvdGU6Cj4gPiA+ID4+IAo+ID4gPiA+PiBIaSBDaHJpcywKPiA+ID4gPj4gT24gRnJpLCBP Y3QgMTMsIDIwMjMgYXQgMDE6Mzk6MTZQTSAtMDUwMCwgQ2hyaXMgTW9yZ2FuIHdyb3RlOgo+ID4g PiA+PiA+IEZyb206IENocmlzIE1vcmdhbiA8bWFjcm9tb3JnYW5AaG90bWFpbC5jb20+Cj4gPiA+ ID4+ID4KPiA+ID4gPj4gPiBUaGUgUG93a2lkZHkgUkdCMzAgNCBpbmNoIHBhbmVsIGlzIGEgNCBp bmNoIDcyMHg3MjAgRFNJIHBhbmVsIHVzZWQgaW4KPiA+ID4gPj4gPiB0aGUgUG93a2lkZHkgUkdC MzAgaGFuZGhlbGQgZ2FtaW5nIGRldmljZS4gQWRkIHN1cHBvcnQgZm9yIGl0Lgo+ID4gPiA+PiA+ Cj4gPiA+ID4+ID4gVE9ETzogVGhlIHBhbmVsIHNlZW1zIHRvIG5vdCByZXN1bWUgcHJvcGVybHkg ZnJvbSBzdXNwZW5kLiBJJ3ZlCj4gPiA+ID4+ID4gY29uZmlybWVkIG9uIHRoZSBvdGhlciBTVDc3 MDMgYmFzZWQgZGV2aWNlcyBpdCB3b3JrcyBjb3JyZWN0bHkuCj4gPiAKPiA+IHNvIHRoaXMgVE9E TyBpdGVtIGNvdWxkIGdvIGF3YXksIHJpZ2h0Pwo+ID4gSSBjYW4gcmVtb3ZlIGl0IHdoZW4gYXBw bHlpbmcgdGhlIHBhdGNoLCBqdXN0IHdhbnQgdG8gbWFrZSBzdXJlCj4gPiBhbGwgcmV2aWV3IGNv bW1lbnRzIGFyZSBhZGRyZXNzZWQgLSBvbmx5IHRoZSBzdXNwZW5kIHRoaW5nIGl0IHNlZW1zLgo+ IAo+IFRoYXQgaXMgY29ycmVjdCwgYnV0IGxldCBtZSBzZW5kIGEgdjIgb2YgdGhpcyBpbnN0ZWFk LiBJJ2xsIHJlbW92ZSB0aGlzCj4gdmVyYmlhZ2UgYW1vbmcgb3RoZXIgZml4ZXMuIEVuZCB1c2Vy cyB3YW50ZWQgbWUgdG8gc2VlIGlmIEkgY291bGQgZ2V0Cj4gdGhpcyBwYW5lbCB0byBydW4gYXQg cHJlY2lzZWx5IDYwaHosIHdoaWNoIEkgYmVsaWV2ZSBJIGFtIGFibGUgdG8gZG8KPiB3aXRoIHRo ZSBhZGRpdGlvbiBvZiBhIG5ldyBQTEwgY2xvY2sgaW4gY2xrX3JrMzU2OC4gSSBiZWxpZXZlIEkg aGF2ZQo+IHRha2VuIGV2ZXJ5IGNvbnN0cmFpbnQgZGV0YWlsZWQgaW4gdGhlIGRhdGFzaGVldCB0 byBoZWFydCBmb3IgdGhlIG5ldwo+IGZyZXF1ZW5jeSBJJ2xsIGJlIHJlcXVlc3RpbmcuIEJ5IHVz aW5nIHRoZSBmcmVxdWVuY3kgb2YgMjkyNTAwMDAwIGZvcgo+IHRoZSBWUExMIEkgY2FuIGdldCB0 aGUgcGFuZWwgcnVubmluZyBhdCA1OS45NjloeiB3aGljaCBpbiBteSB2aWV3IGlzCj4gY2xvc2Ug ZW5vdWdoIHRvIHRoZSBpZGVhbCA1OS45OGh6Lgo+IAo+IEkgYWxzbyBhY2NpZGVudGFsbHkgbGVm dCB0aGUgVUFSVDIgYWN0aXZlIGV2ZW4gdGhvdWdoIHRoaXMgZGV2aWNlIGhhcwo+IG5vIGV4cG9z ZWQgVUFSVCBwb3J0LCBzbyBJIG5lZWQgdG8gZml4IHRoYXQgdG9vIGJ5IGRpc2FibGluZyBpdC4K PiAKPiBMYXN0bHkgSSdsbCBhZGQgbXkgdGVzdGVkIGJ5IHRvIHRoZSBkcmktZGV2ZWwgcGF0Y2hl cyBhcyB3ZWxsLgoKdG9vIGxhdGUgOy0pCgpMb29rcyBsaWtlIHlvdXIgbWFpbCBhbmQgbWUgYXBw bHlpbmcgdGhlIHNlcmllcyBoYXBwZW5lZCBhdCBhIHNpbWlsYXIKdGltZSBhbmQgSSBqdXN0IHNh dyB5b3VyIG1haWwuCgpTbyBpZiB5b3Ugd2FudCB0byBjaGFuZ2UgdGhlIGR0cyBub3csIHBsZWFz ZSBkbyBhIGZvbGxvd3VwIHBhdGNoLgoKVGhhbmtzCkhlaWtvCgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlz dApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D8B1F61D for ; Tue, 17 Oct 2023 07:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42DBFF1 for ; Tue, 17 Oct 2023 00:44:11 -0700 (PDT) Received: from i53875b5b.versanet.de ([83.135.91.91] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsekB-0005qD-9e; Tue, 17 Oct 2023 09:43:59 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Morgan Cc: Chris Morgan , Dragan Simic , Guido =?ISO-8859-1?Q?G=FCnther?= , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, andyshrk@163.com, jagan@edgeble.ai, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, neil.armstrong@linaro.org, megous@megous.com, kernel@puri.sm, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Ondrej Jirman Subject: Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support Date: Tue, 17 Oct 2023 09:43:57 +0200 Message-ID: <3022818.687JKscXgg@diego> In-Reply-To: References: <20231013183918.225666-1-macroalpha82@gmail.com> <2140189.3Lj2Plt8kZ@diego> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_PASS,T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Chris, Am Montag, 16. Oktober 2023, 20:26:58 CEST schrieb Chris Morgan: > On Mon, Oct 16, 2023 at 08:18:25PM +0200, Heiko St=C3=BCbner wrote: > > Hi, > >=20 > > Am Montag, 16. Oktober 2023, 18:07:52 CEST schrieb Dragan Simic: > > > On 2023-10-16 17:52, Chris Morgan wrote: > > > > Confirmed that those pending patches DO fix the panel suspend issue= s.=20 > > > > Thank you. > > >=20 > > > Awesome, that's great to hear! Perhaps a "Tested-by" in the original= =20 > > > LKML thread [1] could help with having the patch pulled sooner. > > >=20 > > > Links: > > > [1]=20 > > > https://lore.kernel.org/lkml/33b72957-1062-1b66-85eb-c37dc5ca259b@red= hat.com/T/ > > >=20 > > >=20 > > > > On Mon, Oct 16, 2023 at 3:41=E2=80=AFAM Guido G=C3=BCnther =20 > > > > wrote: > > > >>=20 > > > >> Hi Chris, > > > >> On Fri, Oct 13, 2023 at 01:39:16PM -0500, Chris Morgan wrote: > > > >> > From: Chris Morgan > > > >> > > > > >> > The Powkiddy RGB30 4 inch panel is a 4 inch 720x720 DSI panel us= ed in > > > >> > the Powkiddy RGB30 handheld gaming device. Add support for it. > > > >> > > > > >> > TODO: The panel seems to not resume properly from suspend. I've > > > >> > confirmed on the other ST7703 based devices it works correctly. > >=20 > > so this TODO item could go away, right? > > I can remove it when applying the patch, just want to make sure > > all review comments are addressed - only the suspend thing it seems. >=20 > That is correct, but let me send a v2 of this instead. I'll remove this > verbiage among other fixes. End users wanted me to see if I could get > this panel to run at precisely 60hz, which I believe I am able to do > with the addition of a new PLL clock in clk_rk3568. I believe I have > taken every constraint detailed in the datasheet to heart for the new > frequency I'll be requesting. By using the frequency of 292500000 for > the VPLL I can get the panel running at 59.969hz which in my view is > close enough to the ideal 59.98hz. >=20 > I also accidentally left the UART2 active even though this device has > no exposed UART port, so I need to fix that too by disabling it. >=20 > Lastly I'll add my tested by to the dri-devel patches as well. too late ;-) Looks like your mail and me applying the series happened at a similar time and I just saw your mail. So if you want to change the dts now, please do a followup patch. Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89661CDB483 for ; Tue, 17 Oct 2023 07:44:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B6A3E10E27F; Tue, 17 Oct 2023 07:44:10 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA4DD10E27F for ; Tue, 17 Oct 2023 07:44:08 +0000 (UTC) Received: from i53875b5b.versanet.de ([83.135.91.91] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsekB-0005qD-9e; Tue, 17 Oct 2023 09:43:59 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Morgan Subject: Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support Date: Tue, 17 Oct 2023 09:43:57 +0200 Message-ID: <3022818.687JKscXgg@diego> In-Reply-To: References: <20231013183918.225666-1-macroalpha82@gmail.com> <2140189.3Lj2Plt8kZ@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: megous@megous.com, devicetree@vger.kernel.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, kernel@puri.sm, sam@ravnborg.org, neil.armstrong@linaro.org, sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org, Chris Morgan , linux-rockchip@lists.infradead.org, robh+dt@kernel.org, Ondrej Jirman , Guido =?ISO-8859-1?Q?G=FCnther?= , jagan@edgeble.ai, Dragan Simic Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Chris, Am Montag, 16. Oktober 2023, 20:26:58 CEST schrieb Chris Morgan: > On Mon, Oct 16, 2023 at 08:18:25PM +0200, Heiko St=C3=BCbner wrote: > > Hi, > >=20 > > Am Montag, 16. Oktober 2023, 18:07:52 CEST schrieb Dragan Simic: > > > On 2023-10-16 17:52, Chris Morgan wrote: > > > > Confirmed that those pending patches DO fix the panel suspend issue= s.=20 > > > > Thank you. > > >=20 > > > Awesome, that's great to hear! Perhaps a "Tested-by" in the original= =20 > > > LKML thread [1] could help with having the patch pulled sooner. > > >=20 > > > Links: > > > [1]=20 > > > https://lore.kernel.org/lkml/33b72957-1062-1b66-85eb-c37dc5ca259b@red= hat.com/T/ > > >=20 > > >=20 > > > > On Mon, Oct 16, 2023 at 3:41=E2=80=AFAM Guido G=C3=BCnther =20 > > > > wrote: > > > >>=20 > > > >> Hi Chris, > > > >> On Fri, Oct 13, 2023 at 01:39:16PM -0500, Chris Morgan wrote: > > > >> > From: Chris Morgan > > > >> > > > > >> > The Powkiddy RGB30 4 inch panel is a 4 inch 720x720 DSI panel us= ed in > > > >> > the Powkiddy RGB30 handheld gaming device. Add support for it. > > > >> > > > > >> > TODO: The panel seems to not resume properly from suspend. I've > > > >> > confirmed on the other ST7703 based devices it works correctly. > >=20 > > so this TODO item could go away, right? > > I can remove it when applying the patch, just want to make sure > > all review comments are addressed - only the suspend thing it seems. >=20 > That is correct, but let me send a v2 of this instead. I'll remove this > verbiage among other fixes. End users wanted me to see if I could get > this panel to run at precisely 60hz, which I believe I am able to do > with the addition of a new PLL clock in clk_rk3568. I believe I have > taken every constraint detailed in the datasheet to heart for the new > frequency I'll be requesting. By using the frequency of 292500000 for > the VPLL I can get the panel running at 59.969hz which in my view is > close enough to the ideal 59.98hz. >=20 > I also accidentally left the UART2 active even though this device has > no exposed UART port, so I need to fix that too by disabling it. >=20 > Lastly I'll add my tested by to the dri-devel patches as well. too late ;-) Looks like your mail and me applying the series happened at a similar time and I just saw your mail. So if you want to change the dts now, please do a followup patch. Thanks Heiko