From: Thomas Monjalon <thomas@monjalon.net>
To: "mb@smartsharesystems.com" <mb@smartsharesystems.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
dev@dpdk.org, "Wu, Wenjun1" <wenjun1.wu@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
david.marchand@redhat.com, bruce.richardson@intel.com,
Shijith Thotton <sthotton@marvell.com>
Subject: Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA
Date: Sun, 19 Feb 2023 11:04:33 +0100 [thread overview]
Message-ID: <3023187.ktpJ11cQ8Q@thomas> (raw)
In-Reply-To: <DM4PR11MB5994E81F93EAD58C697B2B66D7D29@DM4PR11MB5994.namprd11.prod.outlook.com>
29/01/2023 13:35, Zhang, Qi Z:
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> >
> > PMD not announce pmd_supports_disable_iova_as_pa will not be build
> > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> > is not skipped by the build system which cause compile error.
> >
> > The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> > RTE_IOVA_AS_PA is not defined.
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Move this for next-net review.
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
You ack your own patch?
> Applied to dpdk-next-net-intel.
Sorry I don't pull this one, as I think there is a better fix:
we should not handle this option in each driver.
Instead the file drivers/meson.build must be fixed.
next prev parent reply other threads:[~2023-02-19 10:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 12:17 [PATCH] net: not compile PMD AVX library when no IOVA as PA Qi Zhang
2022-12-12 14:52 ` [PATCH v2] net: not build " Qi Zhang
2022-12-12 14:55 ` Qi Zhang
2023-01-29 12:35 ` Zhang, Qi Z
2023-02-19 10:04 ` Thomas Monjalon [this message]
2023-02-19 11:08 ` Thomas Monjalon
2023-02-19 12:01 ` Thomas Monjalon
2023-03-02 13:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3023187.ktpJ11cQ8Q@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
--cc=wenjun1.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.