From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dpdk-dev <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct
Date: Tue, 26 May 2020 15:01:14 +0200 [thread overview]
Message-ID: <3024961.L4zuKXn9mZ@thomas> (raw)
In-Reply-To: <CALBAE1O-vzbVm6R-mDXxeN1CX24yVBzkf7+jmG3vRhpwwaAo8w@mail.gmail.com>
18/02/2020 06:07, Jerin Jacob:
> On Mon, Feb 17, 2020 at 9:08 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > For the ABI compatibility it is better to hide internal data structures
> > from the application as much as possible. But because of some inline
> > functions 'struct eth_dev_ops' can't be hidden completely.
> >
> > Plan is to split the 'struct eth_dev_ops' into two as ones used by
> > inline functions and ones not used, and hide the second part that not
> > used by inline functions completely to the application.
>
> It is a good improvement. IMO, If anything used in fast-path it
> should be in ``struct rte_eth_dev``
> and rest can completely be moved to internal. In this case, if
> `rte_eth_tx_descriptor_status`
> not used on fastpath, Maybe we don't need to maintain the inline
> status and move completely
> to .c file.
>
> Those may be specifics of the work. In general, this change looks good to me.
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
This ack is missing from v3.
Jerin, please could you confirm on v3?
next prev parent reply other threads:[~2020-05-26 13:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:38 [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct Ferruh Yigit
2020-02-18 5:07 ` Jerin Jacob
2020-02-25 12:42 ` Ferruh Yigit
2020-05-26 13:01 ` Thomas Monjalon [this message]
2020-02-18 6:01 ` Stephen Hemminger
2020-02-21 10:40 ` Ferruh Yigit
2020-02-25 10:35 ` Andrew Rybchenko
2020-02-25 11:07 ` Ananyev, Konstantin
2020-02-25 11:19 ` Andrew Rybchenko
2020-02-25 12:28 ` Ferruh Yigit
2020-02-25 12:44 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2020-02-25 15:51 ` Andrew Rybchenko
2020-02-25 16:13 ` Ferruh Yigit
2020-02-25 16:41 ` Andrew Rybchenko
2020-02-25 18:13 ` David Marchand
2020-02-25 18:18 ` Ferruh Yigit
2020-03-04 9:57 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2020-05-24 23:18 ` Thomas Monjalon
2020-05-25 9:11 ` Andrew Rybchenko
2020-05-26 13:55 ` Thomas Monjalon
2020-05-25 10:24 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3024961.L4zuKXn9mZ@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.