From: Federico Vaga <federico.vaga@cern.ch>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
<linux-kernel@vger.kernel.org>
Subject: report: scripts: checkpatch: Spell Checker Does Not Run with '-f'
Date: Thu, 14 Feb 2019 13:48:24 +0100 [thread overview]
Message-ID: <3030138.e1gdHPWlgN@pcbe13614> (raw)
Hello,
Recently I have produce a couple of patches but I get different warnings if I
run checkpatch on the file (-f) or if I run it of a patch file. In particular,
the problem I found is with the spell checker which seems to run only when the
option '-f' is not used. I am wandering if there are other similar cases.
I do not know Perl, so I cannot investigate more, but I have a practical
example. I have this simple patch applied on my tree that introduces a spell
error:
From: Federico Vaga <federico.vaga@cern.ch>
Date: Thu, 14 Feb 2019 13:29:39 +0100
Subject: [PATCH] script: checkpatch: buggy(?) output with -f option
Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
---
drivers/i2c/busses/i2c-ocores.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index b32d67c..f4deb90 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -301,7 +301,7 @@ static int ocores_poll_wait(struct ocores_i2c *i2c)
/* on going transfer */
mask = OCI2C_STAT_TIP;
/*
- * We wait for the data to be transferred (8bit),
+ * We wait for the data to be transfered (8bit),
* then we start polling on the ACK/NACK bit
*/
udelay((8 * 1000) / i2c->bus_clock_khz);
--
2.15.0
And here the outputs from checkpatch
--------- ON FILE ----------------
./script/checkpatch.pl -f drivers/i2c/busses/i2c-ocores.c
total: 0 errors, 0 warnings, 765 lines checked
drivers/i2c/busses/i2c-ocores.c has no obvious style problems and is ready for
submission.
---------- ON PATCH ---------------
./script/checkpatch.pl 0001-script-checkpatch-buggy-output-with-f-option.patch
WARNING: Missing commit description - Add an appropriate one
WARNING: 'transfered' may be misspelled - perhaps 'transferred'?
#20: FILE: drivers/i2c/busses/i2c-ocores.c:304:
+ * We wait for the data to be transfered (8bit),
total: 0 errors, 2 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
0001-script-checkpatch-buggy-output-with-f-option.patch has style problems,
please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
-------------------------
next reply other threads:[~2019-02-14 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 12:48 Federico Vaga [this message]
2019-02-14 14:44 ` report: scripts: checkpatch: Spell Checker Does Not Run with '-f' Joe Perches
2019-02-14 15:03 ` Federico Vaga
2019-02-14 15:19 ` Joe Perches
2019-02-14 15:22 ` Federico Vaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3030138.e1gdHPWlgN@pcbe13614 \
--to=federico.vaga@cern.ch \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.