From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TBLXH-0005Cz-UT
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 04:09:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TBLXC-0003mv-3Q
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 04:09:31 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:43542)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TBLXB-0003mk-RM
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 04:09:26 -0400
Date: Tue, 11 Sep 2012 04:09:25 -0400 (EDT)
From: Alon Levy <alevy@redhat.com>
Message-ID: <303604638.32854461.1347350965011.JavaMail.root@redhat.com>
In-Reply-To: <1347286860-22918-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/4] linux framebuffer display driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

> Hi,
> 
> Undusting an pretty old patch series, rebasing it, testing it, fixing
> a bug or two, fixing codestyle issues:  Qemu can run on the linux
> framebuffer console as graphical display now.

Patch 4 doesn't apply (hmp.h), missing SoB on a few patches. 

Tested with Seabios. Works as advertised, tested console switching, quit, serial console. Some minor point:
 To switch to serial: Ctrl-Alt-1. To switch back to console output you have to release Ctrl & release Alt, then repress them, i.e. can't just release 1 and press 0.

Verified systemtap points using the following script:

$ cat scripts/simple-qemu-trace.py 
#!/usr/bin/env python

import sys

start = sys.argv[1]

for line in sys.stdin:
    if not line.startswith(start):
        continue
    probe = line.split('(')[0]
    print """probe qemu.system.x86_64.%s {
    printf("%s\\n");
}
""" % (probe, probe)

./scripts/simple-qemu-trace.py fbdev < trace-events | sudo stap -v -s1 -I x86_64-softmmu -

> 
> enjoy,
>   Gerd
> 
> Gerd Hoffmann (4):
>   QLIST-ify display change listeners.
>   add unregister_displaychangelistener
>   fbdev: add linux framebuffer display driver.
>   fbdev: add monitor command to enable/disable
> 
>  console.h           |   86 +++--
>  hmp-commands.hx     |   15 +
>  hmp.c               |    9 +
>  hmp.h               |    1 +
>  hw/xenfb.c          |    2 +-
>  qapi-schema.json    |   15 +
>  qemu-options.hx     |    8 +
>  qmp-commands.hx     |    6 +
>  qmp.c               |   17 +
>  sysemu.h            |    1 +
>  trace-events        |   14 +
>  ui/Makefile.objs    |    1 +
>  ui/fbdev.c          |  953
>  +++++++++++++++++++++++++++++++++++++++++++++++++++
>  ui/linux-keynames.h |  388 +++++++++++++++++++++
>  vl.c                |   50 ++-
>  15 files changed, 1518 insertions(+), 48 deletions(-)
>  create mode 100644 ui/fbdev.c
>  create mode 100644 ui/linux-keynames.h
> 
> 
>