From: "Heiko Stübner" <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] optee: support rockchip optee binary release
Date: Sun, 31 Mar 2019 23:02:54 +0200 [thread overview]
Message-ID: <3038349.884Z39obVD@diego> (raw)
In-Reply-To: <46b072af-a06a-07bd-d636-23074ef9c83f@rock-chips.com>
Hi Kever,
Am Freitag, 29. März 2019, 13:16:26 CET schrieb Kever Yang:
> On 03/29/2019 07:25 PM, Philipp Tomsich wrote:
> >> On 29.03.2019, at 12:21, Kever Yang <kever.yang@rock-chips.com> wrote:
> >>
> >> Rockchip provide tee binary release in 'rkbin' repository:
> >> https://github.com/rockchip-linux/rkbin
> >> For some historical reason, rockchip optee binary is using
> >> 'r1' instead of 'lr' as U-Boot entry.
> >>
> >> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> >> ---
> >>
> >> common/spl/spl_optee.S | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/common/spl/spl_optee.S b/common/spl/spl_optee.S
> >> index 8bd1949ddf..092307b3cc 100644
> >> --- a/common/spl/spl_optee.S
> >> +++ b/common/spl/spl_optee.S
> >> @@ -8,5 +8,8 @@
> >>
> >> ENTRY(spl_optee_entry)
> >> ldr lr, =CONFIG_SYS_TEXT_BASE
> >> +#ifdef CONFIG_ARCH_ROCKCHIP
> > Can we make this selectable based on a dedicated config-option? We provide our
> > own OPTEE port for some of our modules and I would like to have this as an opt-in
> > or opt-out option in Kconfig.
>
> I think you are using OPTEE for RK3368/RK3399, right? Then the use case
> is different, you are using OPTEE as bl32 for armv8, and this spl_optee is
> for armv7 only.
> I'm OK to add a Kconfig option if you really have different usage,
> and I think this patch does not break things because the no one use 'r1'
> now.
rk3229 has support in upstream op-tee, so possibly the calling convention
is different with that? And of course there may come a time when people
may want to use upstream-op-tee instead of a binary-blob.
Heiko
next prev parent reply other threads:[~2019-03-31 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 11:21 [U-Boot] [PATCH] optee: support rockchip optee binary release Kever Yang
2019-03-29 11:25 ` Philipp Tomsich
2019-03-29 12:16 ` Kever Yang
2019-03-29 13:26 ` Philipp Tomsich
2019-03-31 21:02 ` Heiko Stübner [this message]
2019-04-01 2:32 ` Kever Yang
2019-04-01 5:42 ` Heiko Stübner
2019-04-01 9:49 ` Kever Yang
2019-04-01 10:09 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3038349.884Z39obVD@diego \
--to=heiko@sntech.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.