From: Szymon Janc <szymon.janc@tieto.com>
To: Marcin Kraglak <marcin.kraglak@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] android/handsfree: Fix possible g_io_channel_shutdown() on NULL channel
Date: Sat, 08 Mar 2014 20:00:34 +0100 [thread overview]
Message-ID: <3039812.7AVkPW4BFl@leonov> (raw)
In-Reply-To: <1394223800-11961-1-git-send-email-marcin.kraglak@tieto.com>
Hi Marcin,
On Friday 07 of March 2014 21:23:16 Marcin Kraglak wrote:
> Return false if listen failed.
> ---
> android/handsfree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/handsfree.c b/android/handsfree.c
> index dc5c73d..fa27f10 100644
> --- a/android/handsfree.c
> +++ b/android/handsfree.c
> @@ -1192,7 +1192,7 @@ static bool enable_hfp_ag(void)
> if (!hfp_server) {
> error("Failed to listen on Handsfree rfcomm: %s", err->message);
> g_error_free(err);
> - goto failed;
> + return false;
> }
>
> rec = hfp_ag_record();
This patch is now pushed, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-03-08 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 20:23 [PATCH 1/5] android/handsfree: Fix possible g_io_channel_shutdown() on NULL channel Marcin Kraglak
2014-03-07 20:23 ` [PATCH 2/5] android/handsfree: Add support for handling incoming SCO connections Marcin Kraglak
2014-03-10 11:48 ` Szymon Janc
2014-03-07 20:23 ` [PATCH 3/5] android/handsfree: Handle connect_audio call Marcin Kraglak
2014-03-07 20:23 ` [PATCH 4/5] android/handsfree: Handle disconnect_audio call Marcin Kraglak
2014-03-07 20:23 ` [PATCH 5/5] android/handsfree: Remove empty line Marcin Kraglak
2014-03-08 19:01 ` Szymon Janc
2014-03-08 19:00 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3039812.7AVkPW4BFl@leonov \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcin.kraglak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.