From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] devtools: add script to verify map files
Date: Mon, 28 May 2018 11:31:31 +0200
Message-ID: <3042130.2JFbLzL6mQ@xps>
References: <20180212161312.31795-1-pbhagavatula@caviumnetworks.com>
 <4156041.IfarTdeXU8@xps>
 <20180528091941.GA15204@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DC8542BAA
 for <dev@dpdk.org>; Mon, 28 May 2018 11:31:34 +0200 (CEST)
In-Reply-To: <20180528091941.GA15204@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

28/05/2018 11:21, Bruce Richardson:
> On Sun, May 27, 2018 at 10:50:58PM +0200, Thomas Monjalon wrote:
> > Sorry for having missed this patch during so long.
> > 
> > 13/02/2018 11:48, Ferruh Yigit:
> > > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote:
> > > > This script checks for the symbols specified in the map files against
> > > > the symbols present in the map file directory.
> > > > Currently, the script checks for map files in drivers and lib directory.
> > > > 
> > > > Example:
> > > > ./devtools/check-map.py
> > > > 
> > > > The following symbols are unused :
> > > > 
> > > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/...
> > > > ['rte_dpaa_pool_table']
> > > > 
> > > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/...
> > > > ['qbman_get_version', 'qbman_swp_send_multiple']
> > > > 
> > > > ...
> > > > 
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > 
> > > +1 to improve our tools.
> > > 
> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > I agree we must have more tools.
> > 
> > I think this check can be a lot simpler as a shell script,
> > instead of Python. It does not need the list features of Python.
> > 
> 
> While the shell version can be shorter, I always find python scripts to be
> far easier to read, understand and therefore maintain than shell scripts.
> While power-users of shell, like yourself, Thomas, can come up with some
> amazing stuff done in shell, it tends to make them very hard to follow for
> us mere mortals.

Some processing are simpler in Python.
But here, the python script is mostly calling some shell commands and
filtering like grep.

For comparison, python version:
	http://dpdk.org/ml/archives/dev/2018-February/090772.html
shell version:
	http://dpdk.org/ml/archives/dev/2018-May/102993.html