All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] buildtools: remove assumption about current work dir
Date: Tue, 27 Jun 2023 15:07:20 +0200	[thread overview]
Message-ID: <3042910.ktpJ11cQ8Q@thomas> (raw)
In-Reply-To: <20230615202446.GC32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

15/06/2023 22:24, Tyler Retzlaff:
> On Wed, Jun 14, 2023 at 03:47:28PM +0100, Bruce Richardson wrote:
> > According to meson documentation, we should not make any assumptions as
> > to what directory a script is called from[1]. The use of "relpath" when
> > processing the output of directory globbing is therefore unsafe, as it
> > was stripping off paths relative to the current directory - which just
> > happened to be the same as the root directory we were processing.
> > 
> > To improve safety, and support meson clones (like muon)  which
> > don't always run things from the currently processed path, we need to
> > explicitly specify that the start parameter for relpath() should be
> > "root" value.
> > 
> > [1] https://mesonbuild.com/Reference-manual_functions.html#run_command
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied, thanks.



      reply	other threads:[~2023-06-27 13:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 14:47 [PATCH] buildtools: remove assumption about current work dir Bruce Richardson
2023-06-15 20:24 ` Tyler Retzlaff
2023-06-27 13:07   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3042910.ktpJ11cQ8Q@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.