From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 1/3] ARM: dts: exynos4210: Add LCD related pinctrl entries Date: Mon, 10 Jun 2013 20:30:50 +0200 Message-ID: <3046864.Enssr3rlNj@flatron> References: <1370603235-11193-1-git-send-email-tushar.behera@linaro.org> <4895761.sVtM2qZnU3@flatron> <51B551C3.8000003@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-bk0-f48.google.com ([209.85.214.48]:41179 "EHLO mail-bk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025Ab3FJSa4 (ORCPT ); Mon, 10 Jun 2013 14:30:56 -0400 In-Reply-To: <51B551C3.8000003@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tushar Behera Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, patches@linaro.org, Sachin Kamat On Monday 10 of June 2013 09:40:43 Tushar Behera wrote: > On 06/08/2013 04:16 PM, Tomasz Figa wrote: > > Hi Tushar, Sachin, > > > > On Friday 07 of June 2013 16:37:13 Tushar Behera wrote: > >> From: Sachin Kamat > >> > >> Adds pinctrl entries required by FIMD. > >> > >> Signed-off-by: Sachin Kamat > >> Signed-off-by: Tushar Behera > >> --- > >> > >> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 75 > >> > >> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi > >> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726 > >> 100644 > >> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi > >> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi > >> @@ -330,6 +330,81 @@ > >> > >> samsung,pin-pud = <3>; > >> samsung,pin-drv = <0>; > >> > >> }; > >> > >> + > >> + pwm0_out: pwm0-out { > >> + samsung,pins = "gpd0-0"; > >> + samsung,pin-function = <2>; > >> + samsung,pin-pud = <0>; > >> + samsung,pin-drv = <0>; > >> + }; > >> + > >> + pwm1_out: pwm1-out { > >> + samsung,pins = "gpd0-1"; > >> + samsung,pin-function = <2>; > >> + samsung,pin-pud = <0>; > >> + samsung,pin-drv = <0>; > >> + }; > > > > Hmm, these two seem to be unrelated. Rebase error? :) > > Not a rebase error. pwm0_out needs to configured to get display on LCD. Please split this into two separate patches than, one adding LCD pin configuration nodes and one adding PWM pin configuration nodes. Also I think it would be better to just define all available PWM outputs not only first two. if you are already at adding PWM pin configurations. Thanks, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Mon, 10 Jun 2013 20:30:50 +0200 Subject: [PATCH 1/3] ARM: dts: exynos4210: Add LCD related pinctrl entries In-Reply-To: <51B551C3.8000003@linaro.org> References: <1370603235-11193-1-git-send-email-tushar.behera@linaro.org> <4895761.sVtM2qZnU3@flatron> <51B551C3.8000003@linaro.org> Message-ID: <3046864.Enssr3rlNj@flatron> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 10 of June 2013 09:40:43 Tushar Behera wrote: > On 06/08/2013 04:16 PM, Tomasz Figa wrote: > > Hi Tushar, Sachin, > > > > On Friday 07 of June 2013 16:37:13 Tushar Behera wrote: > >> From: Sachin Kamat > >> > >> Adds pinctrl entries required by FIMD. > >> > >> Signed-off-by: Sachin Kamat > >> Signed-off-by: Tushar Behera > >> --- > >> > >> arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 75 > >> > >> +++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi > >> b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index 55a2efb..d241726 > >> 100644 > >> --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi > >> +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi > >> @@ -330,6 +330,81 @@ > >> > >> samsung,pin-pud = <3>; > >> samsung,pin-drv = <0>; > >> > >> }; > >> > >> + > >> + pwm0_out: pwm0-out { > >> + samsung,pins = "gpd0-0"; > >> + samsung,pin-function = <2>; > >> + samsung,pin-pud = <0>; > >> + samsung,pin-drv = <0>; > >> + }; > >> + > >> + pwm1_out: pwm1-out { > >> + samsung,pins = "gpd0-1"; > >> + samsung,pin-function = <2>; > >> + samsung,pin-pud = <0>; > >> + samsung,pin-drv = <0>; > >> + }; > > > > Hmm, these two seem to be unrelated. Rebase error? :) > > Not a rebase error. pwm0_out needs to configured to get display on LCD. Please split this into two separate patches than, one adding LCD pin configuration nodes and one adding PWM pin configuration nodes. Also I think it would be better to just define all available PWM outputs not only first two. if you are already at adding PWM pin configurations. Thanks, Tomasz