From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/5 v3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally Date: Mon, 16 Jan 2017 17:50:20 +0200 Message-ID: <3051780.qdkxg3Jpn9@avalon> References: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> <1483472502-16403-5-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24D8E6E388 for ; Mon, 16 Jan 2017 15:50:05 +0000 (UTC) In-Reply-To: <1483472502-16403-5-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: lkml , dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlc2RheSAwMyBKYW4gMjAx NyAxMTo0MTo0MSBKb2huIFN0dWx0eiB3cm90ZToKPiBJbiBjaGFzaW5nIGRvd24gaXNzdWVzIHdp dGggRURJRCBwcm9iaW5nLCBJIGZvdW5kIHNvbWUKPiBkdXBsaWNhdGVkIGJ1dCBpbmNvbXBsZXRl IGxvZ2ljIHVzZWQgdG8gcG93ZXIgdGhlIGNoaXAgb24gYW5kCj4gb2ZmLgo+IAo+IFRoaXMgcGF0 Y2ggcmVmYWN0b3JzIHRoZSBhZHY3NTExX3Bvd2VyX29uL29mZiBmdW5jdGlvbnMsIHNvCj4gdGhl eSBjYW4gYmUgdXNlZCBmb3IgaW50ZXJuYWwgbmVlZHMuCj4gCj4gQ2M6IERhdmlkIEFpcmxpZSA8 YWlybGllZEBsaW51eC5pZT4KPiBDYzogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3Jh Lm9yZz4KPiBDYzogV29sZnJhbSBTYW5nIDx3c2ErcmVuZXNhc0BzYW5nLWVuZ2luZWVyaW5nLmNv bT4KPiBDYzogTGFycy1QZXRlciBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4gQ2M6IExhdXJl bnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KClJldmlld2Vk LWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+ Cgo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTog Sm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jIHwgMTQgKysrKysrKysrKy0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jCj4g Yi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9kcnYuYyBpbmRleCA0Yjkw OTc1Li5kYmRiNzFjCj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3 NTExL2Fkdjc1MTFfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEv YWR2NzUxMV9kcnYuYwo+IEBAIC0zMjUsNyArMzI1LDcgQEAgc3RhdGljIHZvaWQgYWR2NzUxMV9z ZXRfbGlua19jb25maWcoc3RydWN0IGFkdjc1MTEKPiAqYWR2NzUxMSwgYWR2NzUxMS0+cmdiID0g Y29uZmlnLT5pbnB1dF9jb2xvcnNwYWNlID09IEhETUlfQ09MT1JTUEFDRV9SR0I7Cj4gIH0KPiAK PiAtc3RhdGljIHZvaWQgYWR2NzUxMV9wb3dlcl9vbihzdHJ1Y3QgYWR2NzUxMSAqYWR2NzUxMSkK PiArc3RhdGljIHZvaWQgX19hZHY3NTExX3Bvd2VyX29uKHN0cnVjdCBhZHY3NTExICphZHY3NTEx KQo+ICB7Cj4gIAlhZHY3NTExLT5jdXJyZW50X2VkaWRfc2VnbWVudCA9IC0xOwo+IAo+IEBAIC0z NTksMjQgKzM1OSwzMCBAQCBzdGF0aWMgdm9pZCBhZHY3NTExX3Bvd2VyX29uKHN0cnVjdCBhZHY3 NTExICphZHY3NTExKQo+ICAJICogTW9zdCBvZiB0aGUgcmVnaXN0ZXJzIGFyZSByZXNldCBkdXJp bmcgcG93ZXIgZG93biBvciB3aGVuIEhQRCBpcyAKbG93Lgo+ICAJICovCj4gIAlyZWdjYWNoZV9z eW5jKGFkdjc1MTEtPnJlZ21hcCk7Cj4gK30KPiAKPiArc3RhdGljIHZvaWQgYWR2NzUxMV9wb3dl cl9vbihzdHJ1Y3QgYWR2NzUxMSAqYWR2NzUxMSkKPiArewo+ICsJX19hZHY3NTExX3Bvd2VyX29u KGFkdjc1MTEpOwo+ICAJaWYgKGFkdjc1MTEtPnR5cGUgPT0gQURWNzUzMykKPiAgCQlhZHY3NTMz X2RzaV9wb3dlcl9vbihhZHY3NTExKTsKPiAtCj4gIAlhZHY3NTExLT5wb3dlcmVkID0gdHJ1ZTsK PiAgfQo+IAo+IC1zdGF0aWMgdm9pZCBhZHY3NTExX3Bvd2VyX29mZihzdHJ1Y3QgYWR2NzUxMSAq YWR2NzUxMSkKPiArc3RhdGljIHZvaWQgX19hZHY3NTExX3Bvd2VyX29mZihzdHJ1Y3QgYWR2NzUx MSAqYWR2NzUxMSkKPiAgewo+ICAJLyogVE9ETzogc2V0dXAgYWRkaXRpb25hbCBwb3dlciBkb3du IG1vZGVzICovCj4gIAlyZWdtYXBfdXBkYXRlX2JpdHMoYWR2NzUxMS0+cmVnbWFwLCBBRFY3NTEx X1JFR19QT1dFUiwKPiAgCQkJICAgQURWNzUxMV9QT1dFUl9QT1dFUl9ET1dOLAo+ICAJCQkgICBB RFY3NTExX1BPV0VSX1BPV0VSX0RPV04pOwo+ICAJcmVnY2FjaGVfbWFya19kaXJ0eShhZHY3NTEx LT5yZWdtYXApOwo+ICt9Cj4gCj4gK3N0YXRpYyB2b2lkIGFkdjc1MTFfcG93ZXJfb2ZmKHN0cnVj dCBhZHY3NTExICphZHY3NTExKQo+ICt7Cj4gKwlfX2Fkdjc1MTFfcG93ZXJfb2ZmKGFkdjc1MTEp Owo+ICAJaWYgKGFkdjc1MTEtPnR5cGUgPT0gQURWNzUzMykKPiAgCQlhZHY3NTMzX2RzaV9wb3dl cl9vZmYoYWR2NzUxMSk7Cj4gLQo+ICAJYWR2NzUxMS0+cG93ZXJlZCA9IGZhbHNlOwo+ICB9Cgot LSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751227AbdAPPuG (ORCPT ); Mon, 16 Jan 2017 10:50:06 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:51117 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbdAPPuF (ORCPT ); Mon, 16 Jan 2017 10:50:05 -0500 From: Laurent Pinchart To: John Stultz Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/5 v3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally Date: Mon, 16 Jan 2017 17:50:20 +0200 Message-ID: <3051780.qdkxg3Jpn9@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1483472502-16403-5-git-send-email-john.stultz@linaro.org> References: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> <1483472502-16403-5-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, Thank you for the patch. On Tuesday 03 Jan 2017 11:41:41 John Stultz wrote: > In chasing down issues with EDID probing, I found some > duplicated but incomplete logic used to power the chip on and > off. > > This patch refactors the adv7511_power_on/off functions, so > they can be used for internal needs. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart Reviewed-by: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: John Stultz > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 4b90975..dbdb71c > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -325,7 +325,7 @@ static void adv7511_set_link_config(struct adv7511 > *adv7511, adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB; > } > > -static void adv7511_power_on(struct adv7511 *adv7511) > +static void __adv7511_power_on(struct adv7511 *adv7511) > { > adv7511->current_edid_segment = -1; > > @@ -359,24 +359,30 @@ static void adv7511_power_on(struct adv7511 *adv7511) > * Most of the registers are reset during power down or when HPD is low. > */ > regcache_sync(adv7511->regmap); > +} > > +static void adv7511_power_on(struct adv7511 *adv7511) > +{ > + __adv7511_power_on(adv7511); > if (adv7511->type == ADV7533) > adv7533_dsi_power_on(adv7511); > - > adv7511->powered = true; > } > > -static void adv7511_power_off(struct adv7511 *adv7511) > +static void __adv7511_power_off(struct adv7511 *adv7511) > { > /* TODO: setup additional power down modes */ > regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, > ADV7511_POWER_POWER_DOWN, > ADV7511_POWER_POWER_DOWN); > regcache_mark_dirty(adv7511->regmap); > +} > > +static void adv7511_power_off(struct adv7511 *adv7511) > +{ > + __adv7511_power_off(adv7511); > if (adv7511->type == ADV7533) > adv7533_dsi_power_off(adv7511); > - > adv7511->powered = false; > } -- Regards, Laurent Pinchart