All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: dhowells@redhat.com, netfs@lists.linux.dev,
	LKML <linux-kernel@vger.kernel.org>,
	linux-nfs@vger.kernel.org
Subject: Re: "netfs: Can't donate prior to front"
Date: Mon, 10 Feb 2025 14:07:46 +0000	[thread overview]
Message-ID: <3052002.1739196466@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAKPOu+_4mUwYgQtRTbXCmi+-k3PGvLysnPadkmHOyB7Gz0iSMA@mail.gmail.com>

Can you apply the attached patch to your kernel, and then run with:

   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_read/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_rreq/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_sreq/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_failure/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_donate/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_progress/enable

enabled.  If you can capture the trace output (and compress it!), that should
hopefully help debug this.

David

diff --git a/fs/netfs/read_collect.c b/fs/netfs/read_collect.c
index e8624f5c7fcc..8b78c1ec0677 100644
--- a/fs/netfs/read_collect.c
+++ b/fs/netfs/read_collect.c
@@ -312,6 +312,7 @@ static bool netfs_consume_read_data(struct netfs_io_subrequest *subreq, bool was
 	printk("folio: %llx-%llx\n", fpos, fend - 1);
 	printk("donated: prev=%zx next=%zx\n", prev_donated, next_donated);
 	printk("s=%llx av=%zx part=%zx\n", start, avail, part);
+	tracing_off();
 	BUG();
 }
 

  reply	other threads:[~2025-02-10 14:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 18:40 "netfs: Can't donate prior to front" Max Kellermann
2025-02-10 14:07 ` David Howells [this message]
2025-02-10 17:41   ` Max Kellermann
2025-02-10 17:45     ` Max Kellermann
2025-02-10 19:11 ` [PATCH] fs/netfs/read_collect: add to next->prev_donated Max Kellermann
2025-02-14 12:47   ` David Howells
2025-02-20 13:09     ` Max Kellermann
2025-02-20 14:17       ` Greg Kroah-Hartman
2025-02-20 15:00         ` Max Kellermann
2025-02-20 15:10           ` Greg Kroah-Hartman
2025-03-01 14:17           ` Salvatore Bonaccorso
2025-03-01 16:51             ` Max Kellermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3052002.1739196466@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=netfs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.