From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mlx4: replace some offload flags with packet
	type
Date: Thu, 16 Jul 2015 01:05:07 +0200
Message-ID: <30575439.VDcg1RVFpr@xps13>
References: <2161590.Y1eMLetJSj@xps13>
 <1436981535-15539-1-git-send-email-thomas.monjalon@6wind.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8950A0@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 6817C5A7A
 for <dev@dpdk.org>; Thu, 16 Jul 2015 01:06:20 +0200 (CEST)
Received: by wgjx7 with SMTP id x7so44711642wgj.2
 for <dev@dpdk.org>; Wed, 15 Jul 2015 16:06:20 -0700 (PDT)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8950A0@SHSMSX104.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-15 18:06, Zhang, Helin:
> > The workaround for Tx tunnel offloading can now be replaced with packet type
> > flag checking.
> > The ol_flags for IPv4/IPv6 and tunnel Rx offloading are replaced with packet type
> > flags.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
[...]
> > +	uint32_t pkt_type = 0;
> Initial value of 0 seems not needed.
> 
> > +
> > +	if (flags & IBV_EXP_CQ_RX_TUNNEL_PACKET)
> > +		pkt_type |=
> Operand of 'OR' is not needed at all.

Matter of taste (OR allows to add more flags before).

Applied with above changes.