From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Fri, 03 Aug 2018 11:55:14 +0300 Subject: [RESEND PATCH v5 2/3] dt-bindings: display: atmel: optional video-interface of endpoints In-Reply-To: <6fe3e84e-bd9d-0894-df8b-1b40c0f9477d@axentia.se> References: <20180803072308.14962-1-peda@axentia.se> <20180803081128.GA4528@w540> <6fe3e84e-bd9d-0894-df8b-1b40c0f9477d@axentia.se> Message-ID: <3057649.ixkh6hxoBL@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Peter, (CC'ing Sakari Ailus) On Friday, 3 August 2018 11:40:02 EEST Peter Rosin wrote: > On 2018-08-03 10:11, jacopo mondi wrote: > > On Fri, Aug 03, 2018 at 09:23:07AM +0200, Peter Rosin wrote: > >> With bus-type/bus-width properties in the endpoint nodes, the video- > >> interface of the connection can be specified for cases where the > >> heuristic fails to select the correct output mode. This can happen > >> e.g. if not all RGB pins are routed on the PCB; the driver has no > >> way of knowing this, and needs to be told explicitly. > >> > >> This is critical for the devices that have the "conflicting output > >> formats" issue (SAM9N12, SAM9X5, SAMA5D3), since the most significant > >> RGB bits move around depending on the selected output mode. For > >> devices that do not have the "conflicting output formats" issue > >> (SAMA5D2, SAMA5D4), this is completely irrelevant. > >> > >> Acked-by: Boris Brezillon > >> Reviewed-by: Rob Herring > >> Signed-off-by: Peter Rosin > >> --- > >> > >> .../devicetree/bindings/display/atmel/hlcdc-dc.txt | 26 > >> ++++++++++++++++++++++ 1 file changed, 26 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > >> b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt index > >> 82f2acb3d374..9de434a8f523 100644 > >> --- a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > >> +++ b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > >> > >> @@ -15,6 +15,14 @@ Required children nodes: > >> to external devices using the OF graph reprensentation (see > >> ../graph.txt). > >> At least one port node is required. > >> > >> +Optional properties in grandchild nodes: > >> + Any endpoint grandchild node may specify a desired video interface > >> + according to ../../media/video-interfaces.txt, specifically > >> + - bus-type: must be <0>. > > > > Is there any value in specifying this, if it has a fixed value to > > "autodetect"? I understand it's optional, so if nobody else objects, > > feels free to keep it there. > > That's just how media/video-interfaces.txt works. > > bus-type 0 means that other properties describe the bus type. In this > case bus-width is specified, so that means a parallel bus. But bus-width > has no meaning (or may not have) if bus-type is non-zero. But checking > that bus-type for zero in the code seemed like overkill to me since the > driver already knows that it is a parallel bus... > > TL;DR I'd like to keep it. Sakari told me recently that he was planning to introduce explicit bus types for parallel buses (both external sync and BT.656). Sakari, do you want to comment on this ? > >> + - bus-width: recognized values are <12>, <16>, <18> and <24>, and > >> + override any output mode selection heuristic, forcing "rgb444", > >> + "rgb565", "rgb666" and "rgb888" respectively. [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RESEND PATCH v5 2/3] dt-bindings: display: atmel: optional video-interface of endpoints Date: Fri, 03 Aug 2018 11:55:14 +0300 Message-ID: <3057649.ixkh6hxoBL@avalon> References: <20180803072308.14962-1-peda@axentia.se> <20180803081128.GA4528@w540> <6fe3e84e-bd9d-0894-df8b-1b40c0f9477d@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <6fe3e84e-bd9d-0894-df8b-1b40c0f9477d@axentia.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Rosin Cc: Mark Rutland , devicetree@vger.kernel.org, jacopo mondi , Sakari Ailus , Alexandre Belloni , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Ferre , Boris Brezillon , Rob Herring , Jacopo Mondi , Jyri Sarha , Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgUGV0ZXIsCgooQ0MnaW5nIFNha2FyaSBBaWx1cykKCk9uIEZyaWRheSwgMyBBdWd1c3QgMjAx OCAxMTo0MDowMiBFRVNUIFBldGVyIFJvc2luIHdyb3RlOgo+IE9uIDIwMTgtMDgtMDMgMTA6MTEs IGphY29wbyBtb25kaSB3cm90ZToKPiA+IE9uIEZyaSwgQXVnIDAzLCAyMDE4IGF0IDA5OjIzOjA3 QU0gKzAyMDAsIFBldGVyIFJvc2luIHdyb3RlOgo+ID4+IFdpdGggYnVzLXR5cGUvYnVzLXdpZHRo IHByb3BlcnRpZXMgaW4gdGhlIGVuZHBvaW50IG5vZGVzLCB0aGUgdmlkZW8tCj4gPj4gaW50ZXJm YWNlIG9mIHRoZSBjb25uZWN0aW9uIGNhbiBiZSBzcGVjaWZpZWQgZm9yIGNhc2VzIHdoZXJlIHRo ZQo+ID4+IGhldXJpc3RpYyBmYWlscyB0byBzZWxlY3QgdGhlIGNvcnJlY3Qgb3V0cHV0IG1vZGUu IFRoaXMgY2FuIGhhcHBlbgo+ID4+IGUuZy4gaWYgbm90IGFsbCBSR0IgcGlucyBhcmUgcm91dGVk IG9uIHRoZSBQQ0I7IHRoZSBkcml2ZXIgaGFzIG5vCj4gPj4gd2F5IG9mIGtub3dpbmcgdGhpcywg YW5kIG5lZWRzIHRvIGJlIHRvbGQgZXhwbGljaXRseS4KPiA+PiAKPiA+PiBUaGlzIGlzIGNyaXRp Y2FsIGZvciB0aGUgZGV2aWNlcyB0aGF0IGhhdmUgdGhlICJjb25mbGljdGluZyBvdXRwdXQKPiA+ PiBmb3JtYXRzIiBpc3N1ZSAoU0FNOU4xMiwgU0FNOVg1LCBTQU1BNUQzKSwgc2luY2UgdGhlIG1v c3Qgc2lnbmlmaWNhbnQKPiA+PiBSR0IgYml0cyBtb3ZlIGFyb3VuZCBkZXBlbmRpbmcgb24gdGhl IHNlbGVjdGVkIG91dHB1dCBtb2RlLiBGb3IKPiA+PiBkZXZpY2VzIHRoYXQgZG8gbm90IGhhdmUg dGhlICJjb25mbGljdGluZyBvdXRwdXQgZm9ybWF0cyIgaXNzdWUKPiA+PiAoU0FNQTVEMiwgU0FN QTVENCksIHRoaXMgaXMgY29tcGxldGVseSBpcnJlbGV2YW50Lgo+ID4+IAo+ID4+IEFja2VkLWJ5 OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4KPiA+PiBSZXZp ZXdlZC1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4KPiA+PiBTaWduZWQtb2ZmLWJ5 OiBQZXRlciBSb3NpbiA8cGVkYUBheGVudGlhLnNlPgo+ID4+IC0tLQo+ID4+IAo+ID4+ICAuLi4v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2F0bWVsL2hsY2RjLWRjLnR4dCB8IDI2Cj4gPj4g ICsrKysrKysrKysrKysrKysrKysrKysgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKykK PiA+PiAKPiA+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Rpc3BsYXkvYXRtZWwvaGxjZGMtZGMudHh0Cj4gPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZGlzcGxheS9hdG1lbC9obGNkYy1kYy50eHQgaW5kZXgKPiA+PiA4MmYyYWNi M2QzNzQuLjlkZTQzNGE4ZjUyMyAxMDA2NDQKPiA+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZGlzcGxheS9hdG1lbC9obGNkYy1kYy50eHQKPiA+PiArKysgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9hdG1lbC9obGNkYy1kYy50eHQK PiA+PiAKPiA+PiBAQCAtMTUsNiArMTUsMTQgQEAgUmVxdWlyZWQgY2hpbGRyZW4gbm9kZXM6Cj4g Pj4gICB0byBleHRlcm5hbCBkZXZpY2VzIHVzaW5nIHRoZSBPRiBncmFwaCByZXByZW5zZW50YXRp b24gKHNlZQo+ID4+ICAgLi4vZ3JhcGgudHh0KS4KPiA+PiAgIEF0IGxlYXN0IG9uZSBwb3J0IG5v ZGUgaXMgcmVxdWlyZWQuCj4gPj4gCj4gPj4gK09wdGlvbmFsIHByb3BlcnRpZXMgaW4gZ3JhbmRj aGlsZCBub2RlczoKPiA+PiArIEFueSBlbmRwb2ludCBncmFuZGNoaWxkIG5vZGUgbWF5IHNwZWNp ZnkgYSBkZXNpcmVkIHZpZGVvIGludGVyZmFjZQo+ID4+ICsgYWNjb3JkaW5nIHRvIC4uLy4uL21l ZGlhL3ZpZGVvLWludGVyZmFjZXMudHh0LCBzcGVjaWZpY2FsbHkKPiA+PiArIC0gYnVzLXR5cGU6 IG11c3QgYmUgPDA+Lgo+ID4gCj4gPiBJcyB0aGVyZSBhbnkgdmFsdWUgaW4gc3BlY2lmeWluZyB0 aGlzLCBpZiBpdCBoYXMgYSBmaXhlZCB2YWx1ZSB0bwo+ID4gImF1dG9kZXRlY3QiPyBJIHVuZGVy c3RhbmQgaXQncyBvcHRpb25hbCwgc28gaWYgbm9ib2R5IGVsc2Ugb2JqZWN0cywKPiA+IGZlZWxz IGZyZWUgdG8ga2VlcCBpdCB0aGVyZS4KPiAKPiBUaGF0J3MganVzdCBob3cgbWVkaWEvdmlkZW8t aW50ZXJmYWNlcy50eHQgd29ya3MuCj4gCj4gYnVzLXR5cGUgMCBtZWFucyB0aGF0IG90aGVyIHBy b3BlcnRpZXMgZGVzY3JpYmUgdGhlIGJ1cyB0eXBlLiBJbiB0aGlzCj4gY2FzZSBidXMtd2lkdGgg aXMgc3BlY2lmaWVkLCBzbyB0aGF0IG1lYW5zIGEgcGFyYWxsZWwgYnVzLiBCdXQgYnVzLXdpZHRo Cj4gaGFzIG5vIG1lYW5pbmcgKG9yIG1heSBub3QgaGF2ZSkgaWYgYnVzLXR5cGUgaXMgbm9uLXpl cm8uIEJ1dCBjaGVja2luZwo+IHRoYXQgYnVzLXR5cGUgZm9yIHplcm8gaW4gdGhlIGNvZGUgc2Vl bWVkIGxpa2Ugb3ZlcmtpbGwgdG8gbWUgc2luY2UgdGhlCj4gZHJpdmVyIGFscmVhZHkga25vd3Mg dGhhdCBpdCBpcyBhIHBhcmFsbGVsIGJ1cy4uLgo+IAo+IFRMO0RSIEknZCBsaWtlIHRvIGtlZXAg aXQuCgpTYWthcmkgdG9sZCBtZSByZWNlbnRseSB0aGF0IGhlIHdhcyBwbGFubmluZyB0byBpbnRy b2R1Y2UgZXhwbGljaXQgYnVzIHR5cGVzIApmb3IgcGFyYWxsZWwgYnVzZXMgKGJvdGggZXh0ZXJu YWwgc3luYyBhbmQgQlQuNjU2KS4gU2FrYXJpLCBkbyB5b3Ugd2FudCB0byAKY29tbWVudCBvbiB0 aGlzID8KCj4gPj4gKyAtIGJ1cy13aWR0aDogcmVjb2duaXplZCB2YWx1ZXMgYXJlIDwxMj4sIDwx Nj4sIDwxOD4gYW5kIDwyND4sIGFuZAo+ID4+ICsgICBvdmVycmlkZSBhbnkgb3V0cHV0IG1vZGUg c2VsZWN0aW9uIGhldXJpc3RpYywgZm9yY2luZyAicmdiNDQ0IiwKPiA+PiArICAgInJnYjU2NSIs ICJyZ2I2NjYiIGFuZCAicmdiODg4IiByZXNwZWN0aXZlbHkuCgpbc25pcF0KCi0tIApSZWdhcmRz LAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36CD3C28CF6 for ; Fri, 3 Aug 2018 08:54:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5ABB2173F for ; Fri, 3 Aug 2018 08:54:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="IumrAL/s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5ABB2173F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732094AbeHCKtz (ORCPT ); Fri, 3 Aug 2018 06:49:55 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:41856 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727866AbeHCKtz (ORCPT ); Fri, 3 Aug 2018 06:49:55 -0400 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 58ACA112; Fri, 3 Aug 2018 10:54:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1533286474; bh=2v10gNDERp1KH9zbX89NMR08xJXBkXNaTYS3bU3jGqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IumrAL/smnaAVto2r1TKeq35sVXcSfPhJQikzIWn/6XdsP6eEQFdK3uQJq1VHOXwQ 6pL5YkeYQ7HuvGBn1Q/q/UggBj4eHj3HpXkv0nULNu8BG0pJheX/72KnrxUBG3rnQg iPej69QL0vUhT9Vf4oKeUVZjoilNPa0eEnBVmLgc= From: Laurent Pinchart To: Peter Rosin Cc: jacopo mondi , linux-kernel@vger.kernel.org, Boris Brezillon , David Airlie , Rob Herring , Mark Rutland , Nicolas Ferre , Alexandre Belloni , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jyri Sarha , Daniel Vetter , Andrzej Hajda , Russell King - ARM Linux , Jacopo Mondi , Sakari Ailus Subject: Re: [RESEND PATCH v5 2/3] dt-bindings: display: atmel: optional video-interface of endpoints Date: Fri, 03 Aug 2018 11:55:14 +0300 Message-ID: <3057649.ixkh6hxoBL@avalon> Organization: Ideas on Board Oy In-Reply-To: <6fe3e84e-bd9d-0894-df8b-1b40c0f9477d@axentia.se> References: <20180803072308.14962-1-peda@axentia.se> <20180803081128.GA4528@w540> <6fe3e84e-bd9d-0894-df8b-1b40c0f9477d@axentia.se> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, (CC'ing Sakari Ailus) On Friday, 3 August 2018 11:40:02 EEST Peter Rosin wrote: > On 2018-08-03 10:11, jacopo mondi wrote: > > On Fri, Aug 03, 2018 at 09:23:07AM +0200, Peter Rosin wrote: > >> With bus-type/bus-width properties in the endpoint nodes, the video- > >> interface of the connection can be specified for cases where the > >> heuristic fails to select the correct output mode. This can happen > >> e.g. if not all RGB pins are routed on the PCB; the driver has no > >> way of knowing this, and needs to be told explicitly. > >> > >> This is critical for the devices that have the "conflicting output > >> formats" issue (SAM9N12, SAM9X5, SAMA5D3), since the most significant > >> RGB bits move around depending on the selected output mode. For > >> devices that do not have the "conflicting output formats" issue > >> (SAMA5D2, SAMA5D4), this is completely irrelevant. > >> > >> Acked-by: Boris Brezillon > >> Reviewed-by: Rob Herring > >> Signed-off-by: Peter Rosin > >> --- > >> > >> .../devicetree/bindings/display/atmel/hlcdc-dc.txt | 26 > >> ++++++++++++++++++++++ 1 file changed, 26 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > >> b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt index > >> 82f2acb3d374..9de434a8f523 100644 > >> --- a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > >> +++ b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > >> > >> @@ -15,6 +15,14 @@ Required children nodes: > >> to external devices using the OF graph reprensentation (see > >> ../graph.txt). > >> At least one port node is required. > >> > >> +Optional properties in grandchild nodes: > >> + Any endpoint grandchild node may specify a desired video interface > >> + according to ../../media/video-interfaces.txt, specifically > >> + - bus-type: must be <0>. > > > > Is there any value in specifying this, if it has a fixed value to > > "autodetect"? I understand it's optional, so if nobody else objects, > > feels free to keep it there. > > That's just how media/video-interfaces.txt works. > > bus-type 0 means that other properties describe the bus type. In this > case bus-width is specified, so that means a parallel bus. But bus-width > has no meaning (or may not have) if bus-type is non-zero. But checking > that bus-type for zero in the code seemed like overkill to me since the > driver already knows that it is a parallel bus... > > TL;DR I'd like to keep it. Sakari told me recently that he was planning to introduce explicit bus types for parallel buses (both external sync and BT.656). Sakari, do you want to comment on this ? > >> + - bus-width: recognized values are <12>, <16>, <18> and <24>, and > >> + override any output mode selection heuristic, forcing "rgb444", > >> + "rgb565", "rgb666" and "rgb888" respectively. [snip] -- Regards, Laurent Pinchart