From: Ramesh Errabolu <ramesh@linux.ibm.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events
Date: Tue, 21 Apr 2026 16:38:43 -0500 [thread overview]
Message-ID: <305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com> (raw)
In-Reply-To: <20260421171334.GA1684602@rocinante>
On 4/21/2026 12:13 PM, Krzysztof Wilczyński wrote:
> Hello,
>
>> +static struct pci_slot_attribute hotplug_slot_attr_uevent = {
>> + .attr = {.name = "uevent", .mode = S_IFREG | 0200},
>> + .show = NULL,
>> + .store = uevent_write_file
>> +};
> I think, you could use the __ATTR_WO() macro here.
Use of the suggested macro is not appropriate
>
> Thank you!
>
> Krzysztof
next prev parent reply other threads:[~2026-04-21 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 21:39 [PATCH v2 0/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events Ramesh Errabolu
2026-04-16 21:39 ` [PATCH v2 1/1] " Ramesh Errabolu
2026-04-17 9:53 ` Niklas Schnelle
2026-04-20 19:37 ` Ramesh Errabolu
2026-04-21 17:13 ` Krzysztof Wilczyński
2026-04-21 21:38 ` Ramesh Errabolu [this message]
2026-04-22 4:44 ` Krzysztof Wilczyński
[not found] ` <742b8820-4bfe-40ef-85a9-5704af038ee1@linux.ibm.com>
2026-04-22 17:13 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com \
--to=ramesh@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=bhelgaas@google.com \
--cc=gbayer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.