Re: [PATCH] x86/Xen: correct commentary and parameter naming of xen_exchange_memory()

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1421 bytes --]

On 01.07.26 11:55, Jan Beulich wrote:
> As documented in comments in struct xen_memory_exchange, the input to the
> hypercall is a set of MFNs which are to be removed from the domain, plus a
> set of PFNs where the newly allocated MFNs are to appear. Present comment
> and parameter naming don't correctly reflect that.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Should "fns_out" maybe be "fns_inout" to further emphasize the dual
> purpose?

I think so, yes. And I'd like to have that reflected in the comment you are
modifying ...

> 
> --- a/arch/x86/xen/mmu_pv.c
> +++ b/arch/x86/xen/mmu_pv.c
> @@ -2291,18 +2291,19 @@ static void xen_remap_exchanged_ptes(uns
>   }
>   
>   /*
> - * Perform the hypercall to exchange a region of our pfns to point to
> - * memory with the required contiguous alignment.  Takes the pfns as
> - * input, and populates mfns as output.
> + * Perform the hypercall to exchange a region of our pages to point to memory
> + * with the required contiguous alignment.  Takes as input the mfns to trade
> + * in and the pfns where the new pages are to appear, and populates mfns as
> + * output.

... like:

   [...] Takes as input the mfns to trade in (mfns_in) and the pfns where the new
   pages are to appear (fns_inout), and populates mfns as output (fns_inout).

With that:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]