From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v7 02/28] librte_ether: add fields from
	rte_pci_driver to rte_eth_dev_data
Date: Sun, 01 Nov 2015 22:41:01 +0100
Message-ID: <3062831.ssDunZgDdU@xps13>
References: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bernard Iremonger <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id E3E36231C
 for <dev@dpdk.org>; Sun,  1 Nov 2015 22:42:11 +0100 (CET)
Received: by wicll6 with SMTP id ll6so39197021wic.0
 for <dev@dpdk.org>; Sun, 01 Nov 2015 13:42:11 -0800 (PST)
In-Reply-To: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-30 15:08, Bernard Iremonger:
> +/** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */
> +#define RTE_ETH_DEV_DRV_NEED_MAPPING   RTE_PCI_DRV_NEED_MAPPING
> +/** Device needs to be unbound even if no module is provided */
> +#define RTE_ETH_DEV_DRV_FORCE_UNBIND   RTE_PCI_DRV_FORCE_UNBIND
> +/** Device supports link state interrupt */
> +#define RTE_ETH_DEV_INTR_LSC   RTE_PCI_DRV_INTR_LSC
> +/** Device  supports detaching capability */
> +#define RTE_ETH_DEV_DETACHABLE RTE_PCI_DRV_DETACHABLE

Please, use an enum which has a name and can be referenced in the API,
e.g. the variable X contains some X_flags.
You should not try to re-use the same values as the PCI layer since it
will not be possible to map it forever when new buses will enter in the game.

> +/** Device  is a bonded device */
> +#define RTE_ETH_DEV_BONDED 0x0020

Why not having RTE_ETH_DEV_PCAPED? ;)
Please try to remove this flag.