From: Richard Weinberger <richard@nod.at>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Philipp Rosenberger <p.rosenberger@linutronix.de>,
David Woodhouse <dwmw2@infradead.org>,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH 2/2] mtd: rawnand: denali: add more clocks
Date: Tue, 12 Jun 2018 13:05:03 +0200 [thread overview]
Message-ID: <3063058.uoHcm7uEyX@blindfold> (raw)
In-Reply-To: <20180612130329.1c17311f@bbrezillon>
Am Dienstag, 12. Juni 2018, 13:03:29 CEST schrieb Boris Brezillon:
> On Tue, 12 Jun 2018 19:36:06 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> > Maybe, the commit title should be:
> >
> > mtd: rawnand: denali: add more clocks and improve setup_data_interface
>
> Or you split that in 2 commits, one retrieving the new clks, and the
> other one fixing/improving ->setup_data_interface().
Yeah, please split the patch. It needs to go into -stable as well.
One patch should just unbreak the driver.
Thanks,
//richard
next prev parent reply other threads:[~2018-06-12 11:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 10:31 [PATCH 1/2] mtd: rawnand: denali_dt: use dev as a shorthand of &pdev->dev Masahiro Yamada
2018-06-12 10:31 ` [PATCH 2/2] mtd: rawnand: denali: add more clocks Masahiro Yamada
2018-06-12 10:31 ` Masahiro Yamada
2018-06-12 10:36 ` Masahiro Yamada
2018-06-12 11:03 ` Boris Brezillon
2018-06-12 11:05 ` Richard Weinberger [this message]
2018-06-12 11:06 ` Masahiro Yamada
2018-06-18 11:54 ` [PATCH 1/2] mtd: rawnand: denali_dt: use dev as a shorthand of &pdev->dev Miquel Raynal
2018-06-18 12:14 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3063058.uoHcm7uEyX@blindfold \
--to=richard@nod.at \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=p.rosenberger@linutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.