Re: [igt-dev] [PATCH i-g-t] tests: Avoid the name "all"

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 28/07/2022 11:46, Petri Latvala wrote:
> On Tue, Jul 26, 2022 at 10:01:32AM +0100, Tvrtko Ursulin wrote:
>>
>> On 26/07/2022 08:28, Petri Latvala wrote:
>>> If using a subtest or a dynamic subtest name "all", the piglit format
>>> name will contain the string "@all". When filing bugs for test
>>> failures, one needs extra care not to accidentally ping every
>>> developer on gitlab.
>>
>> Three questions:
>>
>> 1)
>> What if someone adds a subtest called all tomorrow or next year?
> 
> You're saying it should be a build-time error? Can be done.

Asking suggestive questions to start with..

>> 2)
>> Are there other keywords with unintended side-effects?
> 
> Usernames and group names. I hope no one makes a subtest "drm"...
> 
>>
>> 3)
>> Is there a component sitting between the IGT output and putting it into
>> GitLab which would be ideally placed to sanitize and do that reliably and
>> with less maintenance effort?
> 
> Not really. In this particular instance the @all mention was in the
> bug title, which is hand crafted with a human-followed naming
> convention.

..because I can think of various (flawed) solutions, but the only 
correct one in my view is to do it at the layer you say does not exist - 
the human layer inputting data to GitLab. Oh well, scratch a future 
proof low-maintenance option in that case.

Regards,

Tvrtko

P.S. However clunky it may be - could add some asserts to library code 
to at least serve as early warning against 'all' and 'drm'? Build or 
runtime is fine, as long as it notifies before the test becomes part of CI.

P.P.S In the bug title really? Markup/mentions are allowed in bug 
titles? That's funny.