From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] librte_lpm: define tbl entry reversely for big endian Date: Fri, 10 Jul 2015 23:23:10 +0200 Message-ID: <3064017.UErnQxGTeU@xps13> References: <1427176700-3911-1-git-send-email-xuelin.shi@freescale.com> <20150519100559.GA11036@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: xuelin.shi@freescale.com Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id EDA9AC42A for ; Fri, 10 Jul 2015 23:24:19 +0200 (CEST) Received: by wgmn9 with SMTP id n9so5383455wgm.0 for ; Fri, 10 Jul 2015 14:24:19 -0700 (PDT) In-Reply-To: <20150519100559.GA11036@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-19 11:05, Bruce Richardson: > On Tue, Mar 24, 2015 at 01:58:20PM +0800, xuelin.shi@freescale.com wrote: > > From: Xuelin Shi > > > > This module uses type conversion between struct and int. > > Also truncation and comparison is used with this int. > > It is not safe for different endian arch. > > > > Add ifdef for big endian struct to fix this issue. > > > > Signed-off-by: Xuelin Shi > > Since nobody objects to this patch, and it looks ok to me: > > Acked-by: Bruce Richardson Applied, thanks