From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
harish.patil@qlogic.com, Hiroyuki Mikita <h.mikita89@gmail.com>
Subject: Re: [PATCH] qede: fix build issue in the cross-compiling mode
Date: Wed, 25 May 2016 19:27:09 +0200 [thread overview]
Message-ID: <3064965.ukpxY9gdBn@xps13> (raw)
In-Reply-To: <5745DA7B.2000505@intel.com>
2016-05-25 18:01, Ferruh Yigit:
> On 5/25/2016 10:41 AM, Jerin Jacob wrote:
> > In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> > instead of just gcc
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > -ifneq (,$(filter gcc gcc48,$(CC)))
> > +ifneq (,$(filter %gcc %gcc48,$(CC)))
>
> What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
> This saves adding gcc version or cross compilation related check.
True!
It could be used instead every occurences of "ifeq ($(CC), icc)" and so on.
cc Hiroyuki Mikita
It is the same issue with http://dpdk.org/patch/13013
next prev parent reply other threads:[~2016-05-25 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 9:41 [PATCH] qede: fix build issue in the cross-compiling mode Jerin Jacob
2016-05-25 17:01 ` Ferruh Yigit
2016-05-25 17:27 ` Thomas Monjalon [this message]
2016-05-26 6:12 ` [PATCH v2] " Jerin Jacob
2016-05-26 6:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3064965.ukpxY9gdBn@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=h.mikita89@gmail.com \
--cc=harish.patil@qlogic.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.